-
-
Notifications
You must be signed in to change notification settings - Fork 357
(3) ref(tracing): Extract Stall Tracking to a standalone integration #3997
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
iOS (legacy) Performance metrics 🚀
|
Contributor
iOS (new) Performance metrics 🚀
|
lucas-zimerman
approved these changes
Aug 7, 2024
Collaborator
lucas-zimerman
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some small nits but non blocking, other than that, LGTM!
Co-authored-by: LucasZF <lucas-zimerman1@hotmail.com>
Contributor
Android (legacy) Performance metrics 🚀
|
6 tasks
This was referenced Aug 8, 2024
Closed
This was referenced Oct 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📢 Type of change
📜 Description
This PR extracts Stall Tracking to a standalone integration. This is possible via client event
spanStartandspanEndwhich is available in JS v8. BeforeReactNativeTracingintegration ensured the Stall Tracking is started and stopped on transaction start and stop.Moving the tracking to a standalone integration will let us measure usage of this feature (enabled integrations telemetry).
This PR introduces user facing breaking change.
Before
After
💚 How did you test it?
sample app, tests
📝 Checklist
sendDefaultPIIis enabledPredecessor to this PR