Skip to content

Conversation

@krystofwoldrich
Copy link
Contributor

@krystofwoldrich krystofwoldrich commented Aug 6, 2024

📢 Type of change

  • Refactoring

📜 Description

This PR extracts Stall Tracking to a standalone integration. This is possible via client event spanStart and spanEnd which is available in JS v8. Before ReactNativeTracing integration ensured the Stall Tracking is started and stopped on transaction start and stop.

Moving the tracking to a standalone integration will let us measure usage of this feature (enabled integrations telemetry).

This PR introduces user facing breaking change.

Before

import Sentry from '@sentry/react-native';
Sentry.init({
  tracesSampleRate: 1.0,
  integrations: [
    new Sentry.ReactNativeTracing({
      enableStallTracking: true, // default true
    }),
  ],
});

After

import Sentry from '@sentry/react-native';
Sentry.init({
  tracesSampleRate: 1.0,
  enableStallTracking: true, // default true
});

💚 How did you test it?

sample app, tests

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled
  • All tests passing
  • No breaking changes

Predecessor to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Aug 6, 2024

iOS (legacy) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1228.02 ms 1229.27 ms 1.24 ms
Size 2.36 MiB 3.06 MiB 713.89 KiB

@github-actions
Copy link
Contributor

github-actions bot commented Aug 6, 2024

iOS (new) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1239.86 ms 1229.02 ms -10.84 ms
Size 2.92 MiB 3.62 MiB 719.78 KiB

Copy link
Collaborator

@lucas-zimerman lucas-zimerman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some small nits but non blocking, other than that, LGTM!

Co-authored-by: LucasZF <lucas-zimerman1@hotmail.com>
@github-actions
Copy link
Contributor

github-actions bot commented Aug 7, 2024

Android (legacy) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 499.06 ms 561.80 ms 62.74 ms
Size 17.73 MiB 20.04 MiB 2.31 MiB

@krystofwoldrich krystofwoldrich changed the title ref(tracing): Extract Stall Tracking to a standalone integration (3) ref(tracing): Extract Stall Tracking to a standalone integration Aug 8, 2024
Base automatically changed from kw/ref-native-frames-integration to v6 August 13, 2024 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants