perf: optimise stall tracking #4185
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📢 Type of change
📜 Description
(WIP)
UPDATE 1:
This pull request optimizes the stall tracking integration by simplifying how the
longestStallTimeis tracked. Previously, thelongestStallTimewas tracked for each transaction (root span) individually within thestatsByRootSpanmap. This approach involved iterating over all transactions during each stall detection, which could be inefficient, especially with a large number of transactions.💡 Motivation and Context
This pull request enhances performance and potentially resolves critical animation flickering issues on iOS devices as reported in Issue #3987. The changes may lead to a more efficient event loop, and smoother animations.
💚 How did you test it?
Running tests that have been in place before. Let me know if we need more test cases.
📝 Checklist
sendDefaultPIIis enabled🔮 Next steps