Misc: CONTRIBUTING: Moves the Optional section above the macOS section for consistency #4140
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antonis
requested review from
krystofwoldrich and
lucas-zimerman
as code owners
CONTRIBUTING.md
Outdated
Comment on lines
94
to
108
| ### Optional | ||
|
|
||
| You can optionally start the Metro bundler if you want to control where it runs: | ||
|
|
||
| ```sh | ||
| yarn start --reset-cache | ||
| ``` | ||
|
|
||
| Run the emulators: | ||
|
|
||
| ```sh | ||
| yarn react-native run-ios | ||
| yarn react-native run-android | ||
| ``` | ||
|
|
Contributor
There was a problem hiding this comment.
Thanks, probably a bad merge on my side.
Actually I think we could remove this section completely.
As this section in the document describes the exact same https://github.com/getsentry/sentry-react-native/pull/4140/files#diff-eca12c0a30e25b4b46522ebf89465a03ba72a03f540796c979137931d8f92055R51-R59
lucas-zimerman
approved these changes
Oct 2, 2024
Collaborator
lucas-zimerman
left a comment
lucas-zimerman
left a comment
There was a problem hiding this comment.
looks good to me !
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📢 Type of change
📜 Description
Moves the Optional section above the macOS section for consistency in the CONTRIBUTING doc
v6💡 Motivation and Context
The macOS section was merged in the middle of the
Running the samplesection (see below). This PR fixes the structure moving the optional section above.💚 How did you test it?
Checked the doc
📝 Checklist
sendDefaultPIIis enabled🔮 Next steps
#skip-changelog