Skip to content

Misc: CONTRIBUTING: Moves the Optional section above the macOS section for consistency #4140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
antonis merged 2 commits into from
Oct 3, 2024
Merged

Misc: CONTRIBUTING: Moves the Optional section above the macOS section for consistency #4140

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0c9f54c
Moves the Optional section above the macOS section for consistency
antonis Oct 2, 2024
c117993
Removes the optional section
antonis Oct 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 1 addition & 15 deletions CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,6 +100,7 @@ cd samples/react-native-macos/
yarn
bundle install
yarn pod-install-legacy
yarn start
```

You can now build and run the project from command line:
Expand All @@ -111,21 +112,6 @@ or by openning the `samples/react-native-macos/macos/sentry-react-native-sample.

_Note that the new architecture is not supported for the macOS sample at this point._

### Optional

You can optionally start the Metro bundler if you want to control where it runs:

```sh
yarn start --reset-cache
```

Run the emulators:

```sh
yarn react-native run-ios
yarn react-native run-android
```

## Develop with sentry-cocoa

Here are step on how to test your changes in `sentry-cocoa` with `sentry-react-native`. We assume you have both repositories cloned in siblings folders.
Expand Down