feat(repos): Add audit logs when auto syncing repositories by wedamija · Pull Request #112056 · getsentry/sentry

wedamija · 2026-04-01T22:08:27Z

Add in audit logs whenever we automatically add, update or disable a repository via webhooks and periodic syncing

src/sentry/plugins/providers/integration_repository.py

src/sentry/integrations/github/tasks/sync_repos.py

src/sentry/plugins/providers/integration_repository.py

src/sentry/integrations/github/tasks/sync_repos.py

src/sentry/integrations/github/tasks/sync_repos_on_install_change.py

src/sentry/plugins/providers/integration_repository.py

src/sentry/integrations/github/tasks/sync_repos.py

src/sentry/plugins/providers/integration_repository.py

src/sentry/integrations/github/tasks/sync_repos.py

Add in audit logs whenever we automatically add, update or disable a repository via webhooks and periodic syncing

src/sentry/plugins/providers/integration_repository.py

cursor

Cursor Bugbot has reviewed your changes and found 1 potential issue.

^{❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.}

^{Reviewed by Cursor Bugbot for commit 784ec6e. Configure here.}

cursor · 2026-04-07T16:56:11Z

src/sentry/plugins/providers/integration_repository.py


-        if missing_repos:
-            raise RepoExistsError(repos=missing_repos)
+        return created_repos, repos_to_update, missing_repos


Spurious REPO_ENABLED logs for already-active repos

Low Severity

The second return value of create_repositories (repos_to_update) is documented as "reactivated" repos, but it also includes repos found via the fallback path at lines 296–303 when create_repository returns None. These repos already exist with the same integration and may already be ACTIVE. Callers treat the entire list as reactivated and emit REPO_ENABLED audit logs for each, producing incorrect customer-facing audit entries for repos that were never actually disabled.

Additional Locations (2)

src/sentry/integrations/github/tasks/sync_repos_on_install_change.py#L136-L144

src/sentry/integrations/github/tasks/sync_repos.py#L194-L202

^{Reviewed by Cursor Bugbot for commit 784ec6e. Configure here.}

getsentry-bot · 2026-04-07T17:12:42Z

PR reverted: 2765803

…112056)" This reverts commit 6f2614c. Co-authored-by: wedamija <6288560+wedamija@users.noreply.github.com>

…112056)" This reverts commit 2765803.

…12378) Re-do of #112056 Add in audit logs whenever we automatically add, update or disable a repository via webhooks and periodic syncing. This failed on master before because our audit log ids conflicts with ids in getsentry.

wedamija requested a review from a team April 1, 2026 22:08

wedamija requested review from a team as code owners April 1, 2026 22:08

github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Apr 1, 2026

vercel bot deployed to Preview April 1, 2026 22:11 View deployment

sentry bot reviewed Apr 1, 2026

View reviewed changes

src/sentry/plugins/providers/integration_repository.py Outdated Show resolved Hide resolved

src/sentry/integrations/github/tasks/sync_repos.py Outdated Show resolved Hide resolved

cursor bot reviewed Apr 1, 2026

View reviewed changes

src/sentry/plugins/providers/integration_repository.py Outdated Show resolved Hide resolved

wedamija force-pushed the danf/github-periodic-repo-sync branch from dc6db0b to 04ffffa Compare April 1, 2026 22:26

wedamija requested a review from a team as a code owner April 1, 2026 22:26

wedamija force-pushed the danf/repo-sync-audit-logs branch from cefd1e8 to 394be4f Compare April 1, 2026 22:26

vercel bot deployed to Preview April 1, 2026 22:29 View deployment

evanpurkhiser approved these changes Apr 2, 2026

View reviewed changes

wedamija force-pushed the danf/github-periodic-repo-sync branch from e1110fd to 9e370c5 Compare April 3, 2026 16:24

wedamija force-pushed the danf/repo-sync-audit-logs branch from 394be4f to e038a92 Compare April 3, 2026 16:25

vercel bot deployed to Preview April 3, 2026 16:26 View deployment

wedamija force-pushed the danf/github-periodic-repo-sync branch 2 times, most recently from 2e87a63 to a342e00 Compare April 3, 2026 22:25

wedamija force-pushed the danf/repo-sync-audit-logs branch from e038a92 to 7af940e Compare April 3, 2026 22:26

vercel bot deployed to Preview April 3, 2026 22:27 View deployment

sentry bot reviewed Apr 3, 2026

View reviewed changes

src/sentry/plugins/providers/integration_repository.py Outdated Show resolved Hide resolved

cursor bot reviewed Apr 3, 2026

View reviewed changes

src/sentry/integrations/github/tasks/sync_repos.py Show resolved Hide resolved

wedamija force-pushed the danf/github-periodic-repo-sync branch from b33f134 to 42a5298 Compare April 6, 2026 17:50

wedamija force-pushed the danf/repo-sync-audit-logs branch from 7af940e to c7591b2 Compare April 6, 2026 17:55

cursor bot reviewed Apr 6, 2026

View reviewed changes

src/sentry/integrations/github/tasks/sync_repos_on_install_change.py Show resolved Hide resolved

src/sentry/integrations/github/tasks/sync_repos_on_install_change.py Show resolved Hide resolved

wedamija force-pushed the danf/repo-sync-audit-logs branch from c7591b2 to 5a69ed2 Compare April 6, 2026 21:08

vercel bot deployed to Preview April 6, 2026 21:10 View deployment

sentry bot reviewed Apr 6, 2026

View reviewed changes

src/sentry/plugins/providers/integration_repository.py Outdated Show resolved Hide resolved

evanpurkhiser reviewed Apr 6, 2026

View reviewed changes

src/sentry/integrations/github/tasks/sync_repos.py Show resolved Hide resolved

evanpurkhiser approved these changes Apr 6, 2026

View reviewed changes

vercel bot deployed to Preview April 6, 2026 22:16 View deployment

sentry bot reviewed Apr 6, 2026

View reviewed changes

src/sentry/plugins/providers/integration_repository.py Outdated Show resolved Hide resolved

cursor bot reviewed Apr 6, 2026

View reviewed changes

src/sentry/integrations/github/tasks/sync_repos.py Show resolved Hide resolved

Base automatically changed from danf/github-periodic-repo-sync to master April 7, 2026 16:23

wedamija added 2 commits April 7, 2026 09:25

feat(repos): Add audit logs when auto syncing repositories

8fb82e7

Add in audit logs whenever we automatically add, update or disable a repository via webhooks and periodic syncing

address pr comments

f466517

wedamija force-pushed the danf/repo-sync-audit-logs branch from 59f330b to f466517 Compare April 7, 2026 16:25

vercel bot deployed to Preview April 7, 2026 16:27 View deployment

sentry bot reviewed Apr 7, 2026

View reviewed changes

src/sentry/plugins/providers/integration_repository.py Outdated Show resolved Hide resolved

don't miss audit logs

784ec6e

vercel bot deployed to Preview April 7, 2026 16:50 View deployment

wedamija enabled auto-merge (squash) April 7, 2026 16:51

cursor bot reviewed Apr 7, 2026

View reviewed changes

wedamija merged commit 6f2614c into master Apr 7, 2026
60 checks passed

wedamija deleted the danf/repo-sync-audit-logs branch April 7, 2026 16:59

wedamija added the Trigger: Revert Add to a merged PR to revert it (skips CI) label Apr 7, 2026

getsentry-bot added a commit that referenced this pull request Apr 7, 2026

Revert "feat(repos): Add audit logs when auto syncing repositories (#…

2765803

…112056)" This reverts commit 6f2614c. Co-authored-by: wedamija <6288560+wedamija@users.noreply.github.com>

wedamija added a commit that referenced this pull request Apr 7, 2026

Reapply "feat(repos): Add audit logs when auto syncing repositories (#…

81d0f5e

…112056)" This reverts commit 2765803.

wedamija mentioned this pull request Apr 7, 2026

feat(repos): Add audit logs when auto syncing repositories take 2 #112378

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat(repos): Add audit logs when auto syncing repositories#112056

feat(repos): Add audit logs when auto syncing repositories#112056
wedamija merged 3 commits intomasterfrom
danf/repo-sync-audit-logs

wedamija commented Apr 1, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

cursor bot left a comment

Uh oh!

cursor bot Apr 7, 2026

Uh oh!

Uh oh!

getsentry-bot commented Apr 7, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

wedamija commented Apr 1, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

cursor bot left a comment

Choose a reason for hiding this comment

Uh oh!

cursor bot Apr 7, 2026

Choose a reason for hiding this comment

Spurious REPO_ENABLED logs for already-active repos

Uh oh!

Uh oh!

getsentry-bot commented Apr 7, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants