Skip to content

ref(grouping): delete unused query parameter from UseEventGroupin…#96813

Merged
shayna-ch merged 1 commit intomasterfrom
shayna-ch/delete-use-event-grouping-info-query-param
Aug 6, 2025
Merged

ref(grouping): delete unused query parameter from UseEventGroupin…#96813
shayna-ch merged 1 commit intomasterfrom
shayna-ch/delete-use-event-grouping-info-query-param

Conversation

@shayna-ch
Copy link
Copy Markdown
Member

@shayna-ch shayna-ch commented Jul 30, 2025 •
edited
Loading

Remove query parameter from useEventGroupingInfo because neither groupingInfo or groupSummary use it as of #96655.

@shayna-ch shayna-ch self-assigned this Jul 30, 2025
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Jul 30, 2025
@shayna-ch shayna-ch requested a review from lobsterkatie July 30, 2025 22:47
@shayna-ch shayna-ch marked this pull request as ready for review July 30, 2025 22:48
cursor[bot]

This comment was marked as outdated.

Sign in to view

@codecov
Copy link
Copy Markdown

codecov bot commented Jul 30, 2025 •
edited
Loading

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
11130 1 11129 10
View the top 1 failed test(s) by shortest run time 
EventGroupingInfo can switch grouping configs
Stack Traces | 1.32s run time 
Error: Unable to find an element with the text: 789. This could be because the text is broken up by multiple elements. In this case, you can provide a function for your text matcher to make your matcher more flexible.

Ignored nodes: comments, script, style
...
    at waitForWrapper (.../sentry/node_modules/.pnpm/@testing-library+dom@10.4.0/node_modules/@.../dom/dist/wait-for.js:163:27)
    at .../sentry/node_modules/.pnpm/@testing-library+dom@10.4.0/node_modules/@.../dom/dist/query-helpers.js:86:33
    at Object.findByText (.../events/groupingInfo/groupingInfoSection.spec.tsx:104:25)

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

@shayna-ch shayna-ch mentioned this pull request Jul 30, 2025
Merged
@shayna-ch shayna-ch marked this pull request as draft July 30, 2025 23:22
@shayna-ch shayna-ch force-pushed the shayna-ch/delete-use-event-grouping-info-query-param branch from 6e85975 to dc318f1 Compare July 31, 2025 21:07
@shayna-ch shayna-ch marked this pull request as ready for review July 31, 2025 21:20
@shayna-ch shayna-ch changed the title fix(groupingInfo): delete unused query parameter from UseEventGroupin… ref(grouping): delete unused query parameter from UseEventGroupin… Jul 31, 2025
lobsterkatie
lobsterkatie approved these changes Aug 4, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@lobsterkatie lobsterkatie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@shayna-ch shayna-ch merged commit 195b212 into master Aug 6, 2025
48 checks passed
@shayna-ch shayna-ch deleted the shayna-ch/delete-use-event-grouping-info-query-param branch August 6, 2025 16:33
andrewshie-sentry pushed a commit that referenced this pull request Aug 7, 2025
@shayna-ch @andrewshie-sentry
ref(grouping): delete unused query parameter from UseEventGroupin… (#…
de44aed 
…96813)
@github-actions github-actions bot locked and limited conversation to collaborators Aug 22, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@cursor cursor[bot] cursor[bot] left review comments

@lobsterkatie lobsterkatie lobsterkatie approved these changes

Assignees

@shayna-ch shayna-ch

Labels

Scope: Frontend Automatically applied to PRs that change frontend components

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@shayna-ch @lobsterkatie