fix(issues): Delete groupingConfigSelect dropdown#96655
Merged
Conversation
github-actions
bot
added
the
Scope: Frontend
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #96655 +/- ##
=======================================
Coverage 80.68% 80.69%
=======================================
Files 8487 8487
Lines 373793 373786 -7
Branches 24241 24239 -2
=======================================
- Hits 301613 301608 -5
+ Misses 71807 71805 -2
Partials 373 373 |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Member
lobsterkatie
left a comment
lobsterkatie
left a comment
There was a problem hiding this comment.
This is looking good!
A few small suggestions below, mostly along the lines of following the breadcrumbs to make sure we're not leaving behind unused code. (If it gets unwieldy, we can always do some of it in a follow-up PR, but good to know the full extent in any case.)
I'd also mention in the PR description that this was only ever released to staff, and that therefore there's no user-facing change here.
- remove test that tested the 'can switch grouping configs' functionality
- The `ConfigHeader` component, which uses `justify-content: space-between`, previously contained two children: a `<div>` wrapper for the `GroupConfigSelect` component and the `FeatureFeedback` component. The removal of the `<div>` wrapper means `ConfigHeader` now has only one child. Consequently, the `FeatureFeedback` component shifts from its previous right-aligned position to the left, resulting in an unintended visual layout change. - The `showGroupingConfig` prop is declared and accepted by the `GroupingInfo` component but is no longer used after the removal of the grouping config selection functionality. This creates dead code and a misleading interface, as the component ignores it.
shayna-ch
force-pushed
the
shayna-ch/delete-grouping-config-select
branch
from
c84e615 to
79d2999
Compare
This was referenced Aug 4, 2025
andrewshie-sentry
pushed a commit
that referenced
this pull request
Aug 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Deleted
groupingConfigSelect.tsxand its references ingroupingInfo.tsx.The groupingConfigSelect dropdown is not needed for the following reasons:
This dropdown was only released to staff, so no there is no user-facing change.