ref(groupingInfo): move feedback button inline with groupInfoSummary#96908
Merged
ref(groupingInfo): move feedback button inline with groupInfoSummary#96908
Conversation
github-actions
bot
added
the
Scope: Frontend
shayna-ch
changed the title
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Member
|
can we switch it to a xs button |
Member
|
might need to remove align-items center |
shayna-ch
force-pushed
the
shayna-ch/feedback-inline-with-grouping-summary
branch
from
89f1b98 to
071a121
Compare
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
scttcper
approved these changes
Aug 4, 2025
andrewshie-sentry
pushed a commit
that referenced
this pull request
Aug 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move Give Feedback button to be more inline with the
groupingInfoSummarycomponent now thatselectGroupingConfigcomponent is gone(#96655). Changed size toxs.Created
feedbackComponentfor consistency across old and new UI.Before:
After:
