release: fix duplicate libs, store symbolic links#17299
release: fix duplicate libs, store symbolic links#17299taronaeo merged 9 commits intoggml-org:masterfrom
Conversation
|
Have you tested the archives on various platforms? AFAIK there are several issues with symlinks in zip. |
|
Tested this on an M1 MacBook Pro and it worked as intended. Any specific OS I should test this on? I can try to spin up VMs to test this coming weekend. |
|
Also, i feel like it would be a better idea to incrementally move to .tar.gz for Linux releases and keep .zip for Windows. WDYT? |
|
Windows in particular would be nice to confirm still works. Moving to tar (not necessarily gzip) on Linux makes sense, not sure why we're using zip? |
Will test it this weekend and report back.
Sweet. I'll start including .tar archives in this PR and maybe we can put a deprecation warning somewhere (maybe README.md?) to inform that Linux releases will be moving to .tar instead of .zip. Then maybe after a few months, we can officially deprecate .zip for Linux. |
61a0bce to
dec86a0
Compare
Can confirm that this still works on Windows. Although I'm unsure why the release now generates Click to expand `llama-cli` output on Windows |
Found out the problem. Quoting from https://github.com/actions/upload-artifact?tab=readme-ov-file#limitations:
So even if we package it as a But I'm not sure how keen are you guys on having 1 additional script to handle this limitation. Please let me know if its okay to have an additional script :) |
07ea8ed to
f95db68
Compare
Signed-off-by: Aaron Teo <aaron.teo1@ibm.com> release: add .tar release Signed-off-by: Aaron Teo <aaron.teo1@ibm.com> release: rm gunzip Signed-off-by: Aaron Teo <aaron.teo1@ibm.com> release: add deprecation notice to release.yml Signed-off-by: Aaron Teo <aaron.teo1@ibm.com> release: fix .tar archives not uploaded Signed-off-by: Aaron Teo <aaron.teo1@ibm.com> release: forgot to upload .tar archives Signed-off-by: Aaron Teo <aaron.teo1@ibm.com> release: fix more missing .tar uploads Signed-off-by: Aaron Teo <aaron.teo1@ibm.com>
f95db68 to
49d4164
Compare
Signed-off-by: Aaron Teo <aaron.teo1@ibm.com>
Oh, that answers my previous question then. :P
Up to @slaren |
|
BTW, I didn't mean to upload plain |
Haha, I was wondering why you would create an archive without compressing the contents :) I will add the compression algorithm once we have decided which to use. I was considering between |
Signed-off-by: Aaron Teo <aaron.teo1@ibm.com>
Signed-off-by: Aaron Teo <aaron.teo1@ibm.com>
Signed-off-by: Aaron Teo <aaron.teo1@ibm.com>
Signed-off-by: Aaron Teo <aaron.teo1@ibm.com>
Signed-off-by: Aaron Teo <aaron.teo1@ibm.com>
Signed-off-by: Aaron Teo <aaron.teo1@ibm.com>
Signed-off-by: Aaron Teo <aaron.teo1@ibm.com>
|
@CISC Requesting your review for this PR again :) It turns out that we can actually upload any archive type (e.g., So I've chosen Please let me know if I need to change anything |
Is anyone else able to review this PR on behalf of @/slaren? From: #17639 (comment) |
CISC
left a comment
There was a problem hiding this comment.
Sorry, missed the latest update.
Is .tar.gz ideal for macOS (as a desktop experience)?
Tested it with the last commit, had no issues with symlinks :) |
fixes #17229
Enables storing of symlink information in the archive to avoid duplicating libraries such as
*.dylib. Saves on storage space and bandwidth.Introduces the
.tar.gzarchive format specifically for Unix/Linux systems while.zipremains for Windows. Adds quick download links to the release description.