Update release workflow to store XCFramework as Zip file#18284
Merged
taronaeo merged 3 commits intoggml-org:masterfrom Dec 22, 2025
Merged
Update release workflow to store XCFramework as Zip file#18284taronaeo merged 3 commits intoggml-org:masterfrom
taronaeo merged 3 commits intoggml-org:masterfrom
Conversation
Co-authored-by: Sigbjørn Skjæret <sigbjorn.skjaeret@scala.com>
Contributor
Author
|
Thanks for your quick review, @CISC. By the way — if any ggml-org owners are interested, I'd be very happy to donate llama.swift, which I created to solve a specific impedance mismatch between Swift Package Manager's implementation of semantic versioning and llama.cpp releases. Just let me know ✌️ |
Anico2
added a commit
to Anico2/llama.cpp
that referenced
this pull request
Jan 15, 2026
…ml-org#18284) * Update release workflow to store XCFramework as Zip file * Add comments to document Zip file requirement for XCFramework * Apply suggestions from code review Co-authored-by: Sigbjørn Skjæret <sigbjorn.skjaeret@scala.com> --------- Co-authored-by: Sigbjørn Skjæret <sigbjorn.skjaeret@scala.com>
blime4
referenced
this pull request
in blime4/llama.cpp
Feb 5, 2026
…8284) * Update release workflow to store XCFramework as Zip file * Add comments to document Zip file requirement for XCFramework * Apply suggestions from code review Co-authored-by: Sigbjørn Skjæret <sigbjorn.skjaeret@scala.com> --------- Co-authored-by: Sigbjørn Skjæret <sigbjorn.skjaeret@scala.com>
Seunghhon
pushed a commit
to Seunghhon/llama.cpp
that referenced
this pull request
Apr 26, 2026
…ml-org#18284) * Update release workflow to store XCFramework as Zip file * Add comments to document Zip file requirement for XCFramework * Apply suggestions from code review Co-authored-by: Sigbjørn Skjæret <sigbjorn.skjaeret@scala.com> --------- Co-authored-by: Sigbjørn Skjæret <sigbjorn.skjaeret@scala.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#17299 updated the release workflow to produce
.tar.gzarchives instead of.zipfiles. However, Swift Package Manager requires XCFramework binary artifacts to be Zip files:Currently, if you try to include llama.cpp in a Swift project...
...you get the following error:
This PR partially reverts 7b6d745, updating the release workflow to package XCFramework artifacts as Zip files once again, and adds a comment documenting this requirement.