ggml-blas: report memory when calling ggml_backend_blas_device_get_memory.#20150
Closed
pwhelan wants to merge 2 commits intoggml-org:masterfrom
Closed
ggml-blas: report memory when calling ggml_backend_blas_device_get_memory.#20150pwhelan wants to merge 2 commits intoggml-org:masterfrom
pwhelan wants to merge 2 commits intoggml-org:masterfrom
Conversation
Member
|
Unfortunately its not a bug. The BLAS backend uses host memory. Setting See: Lines 118 to 127 in f7db3f3 |
Member
|
Closing as not a bug. Feel free to reopen if otherwise. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement memory information retrieval for ggml_backend_blas_device_get_memory. It uses sysinfo on linux, which I tested.
I copied the windows version from #18578. I have no desire to test it on windows and the implementation looks sane. I am also assuming the original author was more familiar with windows.
My reason for fixing this bug is to allow for light weight testing of code that requires querying the currently used memory of a device using BLAS on my laptop.