Skip to content

ggml: update comments for backends which have no memory to report#20157

Merged
taronaeo merged 1 commit intoggml-org:masterfrom
taronaeo:chore/rm-backend-memory-todos
Mar 6, 2026
Merged

ggml: update comments for backends which have no memory to report#20157
taronaeo merged 1 commit intoggml-org:masterfrom
taronaeo:chore/rm-backend-memory-todos

Conversation

@taronaeo
Copy link
Copy Markdown
Member

@taronaeo taronaeo commented Mar 6, 2026

Ref: #20150

This PR updates the comments for backends which have no memory to report. By default, llama.cpp will default to host memory information if the backend reports *free = 0; *total = 0;.

This will help maintainers understand that reporting 0 bytes is not a bug, but rather, allow downstream GGML consumers to decide what they want to do in the event that the backend reports 0 bytes.

Signed-off-by: Aaron Teo <aaron.teo1@ibm.com>
@github-actions github-actions Bot added ggml changes relating to the ggml tensor library for machine learning OpenCL Issues specific to the OpenCL backend labels Mar 6, 2026
@taronaeo
Copy link
Copy Markdown
Member Author

taronaeo commented Mar 6, 2026

CI / ggml-ci-x64-cpu-high-perf (pull_request) failure unrelated to this PR. Merging.

@taronaeo taronaeo merged commit ba2ff79 into ggml-org:master Mar 6, 2026
77 of 78 checks passed
bartowski1182 pushed a commit to bartowski1182/llama.cpp that referenced this pull request Mar 10, 2026
Ethan-a2 pushed a commit to Ethan-a2/llama.cpp that referenced this pull request Mar 20, 2026
Seunghhon pushed a commit to Seunghhon/llama.cpp that referenced this pull request Apr 26, 2026
rsenthilkumar6 pushed a commit to rsenthilkumar6/llama.cpp that referenced this pull request May 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ggml changes relating to the ggml tensor library for machine learning OpenCL Issues specific to the OpenCL backend

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants