Server becomes the source of truth for sampling parameter defaults#20558
Merged
allozaur merged 6 commits intoggml-org:masterfrom Mar 19, 2026
Merged
Server becomes the source of truth for sampling parameter defaults#20558allozaur merged 6 commits intoggml-org:masterfrom
allozaur merged 6 commits intoggml-org:masterfrom
Conversation
Contributor
Author
|
The single model mode still needs to be tested. We can also store overrides per model, but that needs to be done in a separate PR, it's a negative line PR, this simplifie le code. WDYT @allozaur |
Contributor
Author
|
It works in principle, but something doesn't sit right with me; the placeholder updates don't seem reliable. |
Contributor
just tested it on my end and things look normal on my end |
allozaur
requested changes
Mar 19, 2026
allozaur
force-pushed
the
webui/sampling-from-server
branch
from
543f1bf to
92b388a
Compare
allozaur
approved these changes
Mar 19, 2026
Contributor
Author
Actually, it's just a matter of caching child process properties, but from a UX perspective, this PR does the job. |
Ethan-a2
pushed a commit
to Ethan-a2/llama.cpp
that referenced
this pull request
Mar 20, 2026
…gml-org#20558) * webui: make server the source of truth for sampling defaults * webui: fix Custom badge for sampling parameters * webui: log user overrides after server sync * chore: update webui build output * fix: Default values for sampling settings config object * chore: update webui build output --------- Co-authored-by: Aleksander Grygier <aleksander.grygier@gmail.com>
Seunghhon
pushed a commit
to Seunghhon/llama.cpp
that referenced
this pull request
Apr 26, 2026
…gml-org#20558) * webui: make server the source of truth for sampling defaults * webui: fix Custom badge for sampling parameters * webui: log user overrides after server sync * chore: update webui build output * fix: Default values for sampling settings config object * chore: update webui build output --------- Co-authored-by: Aleksander Grygier <aleksander.grygier@gmail.com>
rsenthilkumar6
pushed a commit
to rsenthilkumar6/llama.cpp
that referenced
this pull request
May 1, 2026
…gml-org#20558) * webui: make server the source of truth for sampling defaults * webui: fix Custom badge for sampling parameters * webui: log user overrides after server sync * chore: update webui build output * fix: Default values for sampling settings config object * chore: update webui build output --------- Co-authored-by: Aleksander Grygier <aleksander.grygier@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make sure to read the contributing guidelines before submitting a PR
Server becomes the source of truth for sampling parameter defaults
Sampling defaults in the webui are now empty strings instead of
hardcoded values duplicated from common.h. Empty means "not sent
in the request" (already handled by hasValue()), so the server
decides. Placeholders show the actual server/preset values via /props.
Fixes
Fixes the "Custom" badge that never appeared on sampling parameters
because client defaults always matched server defaults. Now any
user-set value that differs from the server is flagged.
Close #18129