Skip to content

webui: fix --webui-config-file settings not applied on load#20823

Merged
allozaur merged 2 commits intoggml-org:masterfrom
ServeurpersoCom:webui/fix-admin-config-load
Mar 23, 2026
Merged

webui: fix --webui-config-file settings not applied on load#20823
allozaur merged 2 commits intoggml-org:masterfrom
ServeurpersoCom:webui/fix-admin-config-load

Conversation

@ServeurpersoCom
Copy link
Copy Markdown
Contributor

Make sure to read the contributing guidelines before submitting a PR

Most UI settings (systemMessage, theme, sidebar, agentic, etc.) were
missing from SYNCABLE_PARAMETERS, so never extracted from /props.

On top of that, syncWithServerDefaults() stopped writing values into
config after #20558 switched to the empty+placeholder pattern for
sampling params. Sampling params don't need config values (server
decides), but UI settings do since the frontend reads them directly.

Fix: add missing UI settings to SYNCABLE_PARAMETERS, and write
webui_settings into config for non-overridden keys. Sampling params
keep the empty+placeholder pattern unchanged.

Not synced (intentionally): apiKey, custom, disableReasoningParsing,
backend_sampling, mcpServerUsageStats.

@allozaur allozaur merged commit c44a932 into ggml-org:master Mar 23, 2026
6 checks passed
Seunghhon pushed a commit to Seunghhon/llama.cpp that referenced this pull request Apr 26, 2026
…#20823)

* webui: fix --webui-config-file settings not applied on load

* chore: update webui build output
rsenthilkumar6 pushed a commit to rsenthilkumar6/llama.cpp that referenced this pull request May 1, 2026
…#20823)

* webui: fix --webui-config-file settings not applied on load

* chore: update webui build output
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants