Fix segfault on musl when downloading models via --hf-repo#21290
Closed
WhyNotHugo wants to merge 1 commit intoggml-org:masterfrom
Closed
Fix segfault on musl when downloading models via --hf-repo#21290WhyNotHugo wants to merge 1 commit intoggml-org:masterfrom
WhyNotHugo wants to merge 1 commit intoggml-org:masterfrom
Conversation
On musl-based, the default thread stack size is only ~130KB. libstdc++'s std::regex implementation uses deep recursion for backtracking, which exceeds this and cause segfaults parsing redirect URLs with complex regex patterns. Create a download threads with a 1MB stack size, which is sufficient for the regex backtracking depth required by typical HuggingFace redirect URLs. Fixes: ggml-org#21280
Member
|
Way too intrusive IMO, and not really an issue of llama.cpp. Please try this: #21280 (comment) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On musl-based, the default thread stack size is only ~130KB. libstdc++'s std::regex implementation uses deep recursion for backtracking, which exceeds this and cause segfaults parsing redirect URLs with complex regex patterns.
Create a download threads with a 1MB stack size, which is sufficient for the regex backtracking depth required by typical HuggingFace redirect URLs.
Fixes: #21280
Requirements