common : remove regex for gguf split and tag parsing#21294
Closed
angt wants to merge 1 commit intoggml-org:masterfrom
Closed
common : remove regex for gguf split and tag parsing#21294angt wants to merge 1 commit intoggml-org:masterfrom
angt wants to merge 1 commit intoggml-org:masterfrom
Conversation
Signed-off-by: Adrien Gallouët <angt@huggingface.co>
Member
Author
|
Before merging #21290 i want to see if avoiding regex fixes the issue. |
Member
Author
|
Sadly not enough, URLs are too big 👀 |
Member
|
@aldehir what about your conversion to PEG-parser for those? |
Contributor
|
You can write a PEG parser for these pattens. But if the implementation in this PR is having problems, not sure if PEG helps. It would look something like this: aldehir#11 (forgive my AI usage, I'm not at my PC). There's another regex that matches the checksum, is this not in the crash path? It would explode the stack due to repetitions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Try to reduce stack usage by removing regex usage
Additional information
Requirements