Skip to content

[SYCL] Revisited & updated SYCL build documentation#6141

Merged
AidanBeltonS merged 9 commits intoggml-org:masterfrom
OuadiElfarouki:sycl_readme_update
Mar 28, 2024
Merged

[SYCL] Revisited & updated SYCL build documentation#6141
AidanBeltonS merged 9 commits intoggml-org:masterfrom
OuadiElfarouki:sycl_readme_update

Conversation

@OuadiElfarouki
Copy link
Copy Markdown
Contributor

Updated the README-sycl.md, fixed typos and added more clarifications for the different build targets (intel GPUs & Nvidia GPUs so far).
Please let me know what you think @NeoZhangJianyu @airMeng @AidanBeltonS @abhilash1910

@OuadiElfarouki OuadiElfarouki changed the title Revisited & updated SYCL build documentation [SYCL] Revisited & updated SYCL build documentation Mar 18, 2024
Comment thread README-sycl.md Outdated
Comment thread README-sycl.md Outdated
Comment thread README-sycl.md Outdated
Comment thread README-sycl.md Outdated
Comment thread README-sycl.md Outdated
Copy link
Copy Markdown
Contributor

@AidanBeltonS AidanBeltonS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With changes it LGTM!

Copy link
Copy Markdown
Contributor

@ngxson ngxson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice job. Thanks!

@OuadiElfarouki
Copy link
Copy Markdown
Contributor Author

Branch has been rebased, some conflicts with #6151 have been addressed locally.

@NeoZhangJianyu
Copy link
Copy Markdown
Contributor

@OuadiElfarouki
I see there are two parts in this PR:

  1. support NV GPU.
    comments:
  • add links as possible, like check/install CUDA/driver, oneMKL build with CUDA.
  • make the llama.cpp guide compactness and clear.
  1. refactor legacy description.
    comments: avoid change more (that would impact existed user to read it again); don't change the style; keep guide compactness.

Because some my comments are unavailable due to the line number is changed.
I will review again for your next version. So don't need answer my comments above.

@abhilash1910 abhilash1910 self-requested a review March 22, 2024 07:41
@AidanBeltonS AidanBeltonS merged commit 5106ef4 into ggml-org:master Mar 28, 2024
@NeoZhangJianyu
Copy link
Copy Markdown
Contributor

@AidanBeltonS
I have created more comments, but the most of my comments are not handled.
As the original author of this document, I suggest to revert the PR before handle the comments.

hodlen pushed a commit to hodlen/llama.cpp that referenced this pull request Apr 3, 2024
* Revisited & updated SYCL build documentation

* removed outdated comment

* Addressed PR comments

* Trimed white spaces

* added new end line
Seunghhon pushed a commit to Seunghhon/llama.cpp that referenced this pull request Apr 26, 2026
* Revisited & updated SYCL build documentation

* removed outdated comment

* Addressed PR comments

* Trimed white spaces

* added new end line
phuongncn pushed a commit to phuongncn/llama.cpp-gx10-dgx-sparks-deepseekv4 that referenced this pull request Apr 28, 2026
* Revisited & updated SYCL build documentation

* removed outdated comment

* Addressed PR comments

* Trimed white spaces

* added new end line
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants