Run make to build the project#6457
Merged
phymbert merged 1 commit intoggml-org:masterfrom Apr 7, 2024
Merged
Conversation
phymbert
previously requested changes
Apr 3, 2024
according to @cebtenzzre comment, forgive my previous comment
cebtenzzre
approved these changes
Apr 4, 2024
Contributor
|
@limitedAtonement This issue was created by another PR: #6141 The removed code is : If good if you provide both make and cmake here. |
414b7ce to
88b35f7
Compare
Contributor
Author
I wasn't sure how to provide both, so I gave it the old college try. How does that look? |
phymbert
approved these changes
Apr 7, 2024
Contributor
|
OK, I will check and update if needed. Thank you! |
Contributor
|
I think this PR needs another look, from usability point of view . |
Contributor
Author
|
@abhilash1910 What are your concerns? I used the instructions to build (using |
Contributor
|
I test and find the parameter "cmake --build .. xxxx" is wrong in common build env. |
Seunghhon
pushed a commit
to Seunghhon/llama.cpp
that referenced
this pull request
Apr 26, 2026
phuongncn
pushed a commit
to phuongncn/llama.cpp-gx10-dgx-sparks-deepseekv4
that referenced
this pull request
Apr 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Although anyone running
cmakeprobably knows to runmake, we may as well add it for completeness's sake.