Conversation
| cmake --build .. -DLLAMA_SYCL=ON -DCMAKE_C_COMPILER=icx -DCMAKE_CXX_COMPILER=icpx -DLLAMA_SYCL_F16=ON | ||
| # Or without "--build", run "make" next | ||
| # Option 1: Use FP16 for better performance in long-prompt inference | ||
| #cmake .. -DLLAMA_SYCL=ON -DCMAKE_C_COMPILER=icx -DCMAKE_CXX_COMPILER=icpx -DLLAMA_SYCL_F16=ON |
There was a problem hiding this comment.
This line should not start with #.
There was a problem hiding this comment.
FP16 is not recommended. It has worse performance in most of case than fp32.
so, mark by #
There was a problem hiding this comment.
I see, excellent observation. That is not a good way to notate that, though. I think the # should be removed and add to the comment above something like: . Not generally recommended.
There was a problem hiding this comment.
In fact, this cmd is copied from the example/sycl/build.sh at beginning.
But next editor don't know it and modify it again and again. :)
|
When running Using the instructions this pull request creates works as expected. ( |
This method should work well too. In latest version, there are two cmake cmds: |
Co-authored-by: jianyuzh <jianyu.zhang@intel.com>
Co-authored-by: jianyuzh <jianyu.zhang@intel.com>
The build cmd in readme-sycl.md is wrong.
"cmake --build .." is incorrect after verify.
Correct it.