The history view in the lower area is not rendered

[shiena]

Operating System

OS: Windows10
Unity: 2017.1.0p2
GitHub for Unity: v0.16-alpha

Steps to reproduce

1. Click any log in the history view
2. Close the details view
3. Scroll down the history view

When you do not open the detail view, the log is drawn.

[StanleyGoldman]

Thanks @shiena

[missramos13]

You did great

[shiena]

I could fix it with this patch.
However, it is not good as it changes accessibility levels.

diff --git a/src/UnityExtension/Assets/Editor/GitHub.Unity/UI/ChangesetTreeView.cs b/src/UnityExtension/Assets/Editor/GitHub.Unity/UI/ChangesetTreeView.cs
index 5bf4412f..12197e90 100644
--- a/src/UnityExtension/Assets/Editor/GitHub.Unity/UI/ChangesetTreeView.cs
+++ b/src/UnityExtension/Assets/Editor/GitHub.Unity/UI/ChangesetTreeView.cs
@@ -275,7 +275,7 @@ namespace GitHub.Unity
             GUILayout.EndHorizontal();
         }
 
-        public float Height { get; protected set; }
+        public float Height { get; set; }
         public bool Readonly { get; set; }
 
         public IList<GitStatusEntry> Entries
diff --git a/src/UnityExtension/Assets/Editor/GitHub.Unity/UI/HistoryView.cs b/src/UnityExtension/Assets/Editor/GitHub.Unity/UI/HistoryView.cs
index 013c861c..c9a9964d 100644
--- a/src/UnityExtension/Assets/Editor/GitHub.Unity/UI/HistoryView.cs
+++ b/src/UnityExtension/Assets/Editor/GitHub.Unity/UI/HistoryView.cs
@@ -525,6 +525,11 @@ namespace GitHub.Unity
             // Handle culling and selection changes at the end of the last GUI frame
             if (Event.current.type == EventType.Repaint)
             {
+                if (newSelectionIndex == -2)
+                {
+                    changesetTree.Height = 0f;
+                }
+
                 CullHistory();
                 updated = false;

[shiena]

I fixed it without changing accessibility levels, but it is still not good.

diff --git a/src/UnityExtension/Assets/Editor/GitHub.Unity/UI/ChangesetTreeView.cs b/src/UnityExtension/Assets/Editor/GitHub.Unity/UI/ChangesetTreeView.cs
index 5bf4412f..b26692c4 100644
--- a/src/UnityExtension/Assets/Editor/GitHub.Unity/UI/ChangesetTreeView.cs
+++ b/src/UnityExtension/Assets/Editor/GitHub.Unity/UI/ChangesetTreeView.cs
@@ -92,8 +92,15 @@ namespace GitHub.Unity
             Redraw();
         }
 
-        public void UpdateEntries(IList<GitStatusEntry> newEntries)
+        public void UpdateEntries(IList<GitStatusEntry> newEntries = null)
         {
+            if (newEntries == null)
+            {
+                OnCommitTreeChange();
+
+                return;
+            }
+
             // Handle the empty list scenario
             if (!newEntries.Any())
             {
diff --git a/src/UnityExtension/Assets/Editor/GitHub.Unity/UI/HistoryView.cs b/src/UnityExtension/Assets/Editor/GitHub.Unity/UI/HistoryView.cs
index 013c861c..df839d54 100644
--- a/src/UnityExtension/Assets/Editor/GitHub.Unity/UI/HistoryView.cs
+++ b/src/UnityExtension/Assets/Editor/GitHub.Unity/UI/HistoryView.cs
@@ -525,6 +525,11 @@ namespace GitHub.Unity
             // Handle culling and selection changes at the end of the last GUI frame
             if (Event.current.type == EventType.Repaint)
             {
+                if (newSelectionIndex == -2)
+                {
+                    changesetTree.UpdateEntries();
+                }
+
                 CullHistory();
                 updated = false;

[StanleyGoldman]

Hey @shiena, before you drive yourself crazy, @shana has been working on virtual scrolling.
We shouldn't be trying to fill 100+ history items if the user can only see ~20 at a time. Hopefully in implementing that we will fix our layout issues here as well as our performance problems mentioned in #23 and #191.