Skip to content
This repository was archived by the owner on Dec 5, 2024. It is now read-only.

Conversation

@StanleyGoldman
Copy link
Contributor

@StanleyGoldman StanleyGoldman commented Dec 13, 2017

A lot of good stuff...

  • Re-implemented the log history list in HistoryView
  • Added the new Tree to the HistoryView
  • Removed the old tree functionality
  • Added functionality to Tree to handle focus and global selection

Comprised of:

Fixes: #180

The HistoryView implemented a lot of functionality to handle virtual scrolling that was different to how they were approached in the Tree control. It was also hard to isolate code that handled the log from the code that handled the log entries.

In order to resolve this I refactored the HistoryView's handling of the list to HistoryControl.

  • Resolved issues that attempt to control the visible area
  • Maintains scroll position if possible when loading entries
  • Maintains selected entry if possible when loading entries
  • Added functionality to display a Tree control at the bottom of the HistoryView
  • Fixed placement issues in the HistoryControl and Tree controls
  • Initialized Tree controls in field initializers to fix an issue where Tree controls were instantiated without their properties set
  • Creating a means to track nodes with asset ids in ChangesTree
  • Adding functionality to set the global selection when a tree node is selected that is associated with a project asset
  • Adding functionality to change the selected tree node when the global selection is changed to an asset that is represented in the ChangesTree
  • Adding functionality to channel window focus to Tree objects so they can display the proper styles

Previous pull requests have added and customized a new tree control which encapsulates and expands upon all the functionality provided by our old tree control. We've replaced all usages of this previous tree control.

  • Allowing for the rendering of Tree nodes to reflect it's disabled state
  • Channeling busy state from ChangesView to it's ChangesTree

StanleyGoldman and others added 25 commits November 30, 2017 10:05
…ing-old-tree-code

# Conflicts:
#	src/GitHub.Api/GitHub.Api.csproj
#	src/tests/UnitTests/UnitTests.csproj
# Conflicts:
#	src/GitHub.Api/GitHub.Api.csproj
#	src/tests/UnitTests/UnitTests.csproj
…/history-detail-tree-view

# Conflicts:
#	src/UnityExtension/Assets/Editor/GitHub.Unity/UI/ChangesView.cs
This was referenced Dec 14, 2017
Copy link

@drguthals drguthals left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Roll it up!

@StanleyGoldman StanleyGoldman merged commit 22c9217 into master Dec 14, 2017
@StanleyGoldman StanleyGoldman deleted the enhancements/history-detail-tree-view-rollup branch December 14, 2017 20:24
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The history view in the lower area is not rendered

3 participants