Skip to content
This repository was archived by the owner on Dec 5, 2024. It is now read-only.

Correcting global selection abuse #536

Merged
StanleyGoldman merged 9 commits into from
Dec 14, 2017
Merged

Correcting global selection abuse #536

StanleyGoldman merged 9 commits into from
Dec 14, 2017

Conversation

@StanleyGoldman
Copy link
Contributor

@StanleyGoldman StanleyGoldman commented Dec 14, 2017 •
edited
Loading

Note: This PR targets enhancements/history-detail-tree-view-rollup #528

  • Creating a means to track nodes with asset ids in ChangesTree
  • Adding functionality to set the global selection when a tree node is selected that is associated with a project asset
  • Adding functionality to change the selected tree node when the global selection is changed to an asset that is represented in the ChangesTree
  • Adding functionality to channel window focus to Tree objects so they can display the proper styles

@StanleyGoldman StanleyGoldman mentioned this pull request Dec 14, 2017
Merged
5 tasks
drguthals
drguthals approved these changes Dec 14, 2017
View reviewed changes
Copy link

@drguthals drguthals left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@StanleyGoldman StanleyGoldman merged commit 67adb7b into enhancements/history-detail-tree-view-rollup Dec 14, 2017
@StanleyGoldman StanleyGoldman deleted the fixes/global-selection-abuse branch December 14, 2017 20:06
@snyk-bot snyk-bot mentioned this pull request Jan 29, 2022
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@drguthals drguthals drguthals approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

ready-for-review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@StanleyGoldman @drguthals