This repository was archived by the owner on Dec 5, 2024. It is now read-only.
Refactor views to update settings in MaybeUpdateData #275
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
2 tasks
Other places in the code call IsFavourite with other types of objects that aren't strings (like a GitBranch instance). We either have overloads for all of them or we just take a string and the caller should know what to pass us, less of an API footprint to worry about.
shana
reviewed
Sep 8, 2017
| public override void InitializeView(IView parent) | ||
| { | ||
| base.InitializeView(parent); | ||
| usageTracker = Manager != null && Manager.UsageTracker != null ? Manager.UsageTracker : null; |
Member
There was a problem hiding this comment.
This is not needed, the Manager is always guaranteed to exist
Member
There was a problem hiding this comment.
UsageTracker is never null either so we don't have to worry about that
shana
approved these changes
Sep 8, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.