This repository was archived by the owner on Dec 5, 2024. It is now read-only.
Refactoring RepositoryManager and Repository#324
Merged
Conversation
StanleyGoldman
commented
Sep 15, 2017
Contributor
Author
StanleyGoldman
left a comment
StanleyGoldman
left a comment
There was a problem hiding this comment.
Documenting changes of Active to Current
StanleyGoldman
commented
Sep 15, 2017
Contributor
Author
StanleyGoldman
left a comment
StanleyGoldman
left a comment
There was a problem hiding this comment.
Explaining the crux of these changes
StanleyGoldman
force-pushed
the
fixes/repository-refactor
branch
from
a9f7492 to
3e940a6
Compare
StanleyGoldman
force-pushed
the
fixes/repository-refactor
branch
from
3e940a6 to
45a0150
Compare
StanleyGoldman
commented
Sep 15, 2017
Contributor
Author
StanleyGoldman
left a comment
StanleyGoldman
left a comment
There was a problem hiding this comment.
Documenting some simpler function moves
…y-refactor # Conflicts: # src/tests/IntegrationTests/Events/RepositoryManagerTests.cs # src/tests/TestUtils/Events/IRepositoryManagerListener.cs # src/tests/UnitTests/Repository/RepositoryManagerTests.cs
StanleyGoldman
force-pushed
the
fixes/repository-refactor
branch
from
31e609f to
6e77812
Compare
shana
reviewed
Oct 11, 2017
|
|
||
| private Action<string> Repository_OnCurrentBranchChanged() | ||
| { | ||
| return s => Refresh(); |
Member
There was a problem hiding this comment.
You can't call Refresh directly here, this is triggered from a different thread, you need to shuffle it off to the UI thread.
shana
reviewed
Oct 11, 2017
| { | ||
| base.OnEnable(); | ||
| AttachHandlers(Repository); | ||
| UpdateLog(); |
Member
There was a problem hiding this comment.
We shouldn't be updating the log here, this gets called every time Unity goes into play mode. The history view should only be loading the log if there's nothing in it, otherwise it should listen for a log update event from the repository and updating the UI only then.
neuroKip
approved these changes
Oct 11, 2017
…r-events-tweak Using TryGet to fire events
…events Split event processing and process firing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ActiveBranchandActiveRemoteinstead ofCurrentBranchandCurrentRemoteRepositoryManagertoRepositoryRepositoryManagerto reflect the concept of "Updates"Repositoryto reflect the concept of "Changes"RepositoryManagerTestsunit tests as they were disabled and getting out of dateRepositoryManagerTestsRepositoryTestsDepends on: