Adding and using the CacheManager

[StanleyGoldman]

Fixes #357
Fixes #344
Fixes #343

Depends on:

• Adding a CacheManager #384
• Refactoring Window.MaybeUpdateData #391
• Changing a nullable GitStatus operations to non nullable #392
• Attaching and detaching handlers at the right time #393
• Removing pragma disable of 649 #394
• Removing branch favorite functionality #396
• Gross copy pasta error with removing a remote branch #397
• Making GitLock serializable #399
• Changing the struct GitBranch to use a default constructor and fields #389

[shana]

Let's get this show on the road

[StanleyGoldman]

I was not sure what to do with data that was "derived" from cached data".
In the end I decided to lazily determine that data in the getters

Unity/src/GitHub.Api/Git/Repository.cs

Lines 600 to 639 in 08705a7

	public UriString CloneUrl
	{
	get
	{
	if (cloneUrl == null)
	{
	var currentRemote = CurrentRemote;
	if (currentRemote.HasValue && currentRemote.Value.Url != null)
	{
	cloneUrl = new UriString(currentRemote.Value.Url);
	}
	}
	return cloneUrl;
	}
	private set
	{
	cloneUrl = value;
	}
	}
	public string Name
	{
	get
	{
	if (name == null)
	{
	var url = CloneUrl;
	if (url != null)
	{
	name = url.RepositoryName;
	}
	else
	{
	name = LocalPath.FileName;
	}
	}
	return name;
	}
	private set { name = value; }
	}

I realize now that this function repeats the functionality to determine Name and CloneUrl.

Unity/src/GitHub.Api/Git/Repository.cs

Lines 463 to 477 in 08705a7

	private void UpdateRepositoryInfo()
	{
	if (CurrentRemote.HasValue)
	{
	CloneUrl = new UriString(CurrentRemote.Value.Url);
	Name = CloneUrl.RepositoryName;
	Logger.Trace("CloneUrl: {0}", CloneUrl.ToString());
	}
	else
	{
	CloneUrl = null;
	Name = LocalPath.FileName;
	Logger.Trace("CloneUrl: [NULL]");
	}
	}

[StanleyGoldman]

I have a dirty underbelly here...

IRemoteConfigBranchDictionary should no longer implement IDictionary< ... , IDictionary< ... , ... >>
That is left over from attempts to use SerializableDictionary. And as a result creates this mess here. 😓

Unity/src/UnityExtension/Assets/Editor/GitHub.Unity/ApplicationCache.cs

Lines 299 to 397 in 08705a7

	IEnumerator<KeyValuePair<string, IDictionary<string, ConfigBranch>>> IEnumerable<KeyValuePair<string, IDictionary<string, ConfigBranch>>>.GetEnumerator()
	{
	throw new NotImplementedException();
	//return AsDictionary
	// .Select(pair => new KeyValuePair<string, IDictionary<string, ConfigBranch>>(pair.Key, pair.Value.AsDictionary))
	// .GetEnumerator();
	}
	void ICollection<KeyValuePair<string, IDictionary<string, ConfigBranch>>>.Add(KeyValuePair<string, IDictionary<string, ConfigBranch>> item)
	{
	throw new NotImplementedException();
	//Guard.ArgumentNotNull(item, "item");
	//Guard.ArgumentNotNull(item.Value, "item.Value");
	//
	//var serializableDictionary = item.Value as SerializableDictionary<string, ConfigBranch>;
	//if (serializableDictionary == null)
	//{
	// serializableDictionary = new SerializableDictionary<string, ConfigBranch>(item.Value);
	//}
	//
	//Add(item.Key, serializableDictionary);
	}
	bool ICollection<KeyValuePair<string, IDictionary<string, ConfigBranch>>>.Contains(KeyValuePair<string, IDictionary<string, ConfigBranch>> item)
	{
	throw new NotImplementedException();
	}
	void ICollection<KeyValuePair<string, IDictionary<string, ConfigBranch>>>.CopyTo(KeyValuePair<string, IDictionary<string, ConfigBranch>>[] array, int arrayIndex)
	{
	throw new NotImplementedException();
	}
	bool ICollection<KeyValuePair<string, IDictionary<string, ConfigBranch>>>.Remove(KeyValuePair<string, IDictionary<string, ConfigBranch>> item)
	{
	throw new NotImplementedException();
	}
	bool ICollection<KeyValuePair<string, IDictionary<string, ConfigBranch>>>.IsReadOnly
	{
	get { throw new NotImplementedException(); }
	}
	void IDictionary<string, IDictionary<string, ConfigBranch>>.Add(string key, IDictionary<string, ConfigBranch> value)
	{
	throw new NotImplementedException();
	}
	bool IDictionary<string, IDictionary<string, ConfigBranch>>.TryGetValue(string key, out IDictionary<string, ConfigBranch> value)
	{
	value = null;
	Dictionary<string, ConfigBranch> branches;
	if (TryGetValue(key, out branches))
	{
	value = branches;
	return true;
	}
	return false;
	}
	IDictionary<string, ConfigBranch> IDictionary<string, IDictionary<string, ConfigBranch>>.this[string key]
	{
	get
	{
	throw new NotImplementedException();
	//var dictionary = (IDictionary<string, IDictionary<string, ConfigBranch>>)this;
	//IDictionary<string, ConfigBranch> value;
	//if (!dictionary.TryGetValue(key, out value))
	//{
	// throw new KeyNotFoundException();
	//}
	//
	//return value;
	}
	set
	{
	throw new NotImplementedException();
	//var dictionary = (IDictionary<string, IDictionary<string, ConfigBranch>>)this;
	//dictionary.Add(key, value);
	}
	}
	ICollection<string> IDictionary<string, IDictionary<string, ConfigBranch>>.Keys
	{
	get
	{
	throw new NotImplementedException();
	}
	}
	ICollection<IDictionary<string, ConfigBranch>> IDictionary<string, IDictionary<string, ConfigBranch>>.Values
	{
	get
	{
	return Values.Cast<IDictionary<string,ConfigBranch>>().ToArray();
	}
	}