This repository was archived by the owner on Dec 5, 2024. It is now read-only.
A simpler data update method to avoid spamming GitClient #423
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…oj-view-spam # Conflicts: # src/UnityExtension/Assets/Editor/GitHub.Unity/UI/UserSettingsView.cs
This was referenced Nov 9, 2017
shana
changed the base branch from
master
to
fixes/git-client-should-return-user
shana
changed the base branch from
fixes/git-client-should-return-user
to
master
shana
reviewed
Nov 10, 2017
| newGitEmail = gitEmail = Repository.User.Email; | ||
| GitClient.GetConfigUserAndEmail() | ||
| .ThenInUI((success, user) => { | ||
| if (success && !String.IsNullOrEmpty(user.Name) && !String.IsNullOrEmpty(user.Email)) |
Member
There was a problem hiding this comment.
What happens if this is empty? Do we not want to show that?
shana
approved these changes
Nov 10, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
UserSettingsViewis currently requesting the user name and email from theGitClientinside it's display loop. This PR fixes up the logic so we can refresh at a normal rate until we have a cache for user data in #412Depends on: