This repository was archived by the owner on Dec 5, 2024. It is now read-only.
Adding functionality to GitClient to set user info #426
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
StanleyGoldman
force-pushed
the
fixes/git-client-set-user
branch
from
1f2c659 to
8b57bb9
Compare
3 tasks
drguthals
approved these changes
Nov 15, 2017
jcansdale
approved these changes
Nov 16, 2017
Contributor
jcansdale
left a comment
jcansdale
left a comment
There was a problem hiding this comment.
Wow, Unity UI programming takes some getting used to! This looks good from what I can work out. 👍
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitClientwill need to perform certain cache operations after the user is saved. In order to take a smaller step towards that goal I'm centralizing the functionality to set the git user and email inGitClientBeginChangeCheck/EndChangeChecksequence. This ensures thatneedsSavingis only calculated when the textbox values have changed.Depends on: