This repository was archived by the owner on Dec 5, 2024. It is now read-only.
Repository using cache invalidation events to update data #436
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…/repository-initialize-git-commands
1 task
…/repository-initialize-git-commands
grokys
reviewed
Nov 14, 2017
| { | ||
| if (!firstRunAtValue.HasValue) | ||
| { | ||
| firstRunAtValue = DateTimeOffset.Parse(firstRunAtString); |
There was a problem hiding this comment.
Should you be passing a CultureInfo to these parse methods, or is it OK that they're being parsed using the CurrentCulture?
Contributor
Author
There was a problem hiding this comment.
I don't have a good answer here, I'm going to use a lifeline (i.e. @shana)
7 tasks
StanleyGoldman
changed the base branch from
master
to
enhancements/repository-watcher-refactor-rollup
3 tasks
…ixes/repository-initialize-git-commands
drguthals
approved these changes
Nov 22, 2017
drguthals
left a comment
drguthals
left a comment
There was a problem hiding this comment.
Makes sense - thanks for a good description.
StanleyGoldman
merged commit 500c279
into
enhancements/repository-watcher-refactor-rollup
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: This branch targets
enhancements/repository-watcher-refactor-rollup#461Related to: #409
Depends on:
A simpler part of the solution to #409.
Due to the changes in #434, the git log, git lock and git status caches throw an "Invalid" event on "First Run". (The true in the constructor..)
Unity/src/UnityExtension/Assets/Editor/GitHub.Unity/ApplicationCache.cs
Line 884 in 8a9554f
Unity/src/UnityExtension/Assets/Editor/GitHub.Unity/ApplicationCache.cs
Line 825 in 8a9554f
Unity/src/UnityExtension/Assets/Editor/GitHub.Unity/ApplicationCache.cs
Line 766 in 8a9554f
We can use that invalid event to accurately update data in
Repository