This repository was archived by the owner on Dec 5, 2024. It is now read-only.
Removing Octokit #611
Merged
Removing Octokit #611
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StanleyGoldman
force-pushed
the
features/octorun-js
branch
from
9a312c9 to
76aaaef
Compare
# Conflicts: # src/GitHub.Api/Authentication/LoginManager.cs # src/UnityExtension/Assets/Editor/GitHub.Unity/GitHub.Unity.csproj
shana
suggested changes
Mar 8, 2018
| { | ||
| command.Append(" -d "); | ||
| command.Append(newRepository.Description); | ||
| command.Append(description); |
Member
There was a problem hiding this comment.
This needs quotes around it for the command line to parse properly
| { | ||
| var executingAssembly = typeof(ApplicationConfiguration).Assembly; | ||
| AssemblyName = executingAssembly.GetName(); | ||
| ProductHeader = new ProductHeaderValue(ApplicationInfo.ApplicationSafeName, AssemblyName.Version.ToString()); |
Member
There was a problem hiding this comment.
Not related directly to this PR, but you should make sure this information is sent along with the requests in the node app, so you might need to set it in the environment as well.
| return new LoginResultData(LoginResultCodes.Failed, Localization.LoginFailed, host); | ||
| } | ||
| await keychain.Clear(host, false); | ||
| return new LoginResultData(LoginResultCodes.Failed, Localization.LoginFailed, host); |
Member
There was a problem hiding this comment.
This is missing the other error conditions like locked out and the workaround for enterprise, isn't it?
Contributor
Author
# Conflicts: # script # src/GitHub.Api/Application/ApiClient.cs # src/GitHub.Api/Authentication/LoginManager.cs
This was referenced Mar 9, 2018
shana
approved these changes
Mar 9, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This targets #599 and does the work of removing Octokit from the application.
This includes libraries and a special solution used for debugging Octokit.
The majority of code changes to the application are removing
IGitHubClientand credentials objects.