Skip to content
This repository was archived by the owner on Dec 5, 2024. It is now read-only.

Making sure path for console matches ProcessEnvironment #662

Merged
shana merged 1 commit into from
Apr 5, 2018
Merged

Making sure path for console matches ProcessEnvironment #662

shana merged 1 commit into from
Apr 5, 2018

Conversation

@StanleyGoldman
Copy link
Contributor

@StanleyGoldman StanleyGoldman commented Mar 29, 2018 •
edited
Loading

DO NOT MERGE: This is part of #663

Part of the problems identified in #659

ProcessEnvironment sets the PATH variable to GHU_FULLPATH exactly.
When opening a console window ProcessManager pre-pends GHU_FULLPATH to the current PATH
Which has the effect of hiding the git lfs error in #659.

Instead it should be setting path to exactly GHU_FULLPATH.

This was referenced Mar 29, 2018
Closed
Merged
@shana shana merged commit 8f3800c into master Apr 5, 2018
@StanleyGoldman StanleyGoldman deleted the fixes/open-shell-standard-path branch April 5, 2018 19:16
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@shana shana shana approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

ready-for-review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@StanleyGoldman @shana