This repository was archived by the owner on Dec 5, 2024. It is now read-only.
Updating display correctly when the remote is removed #91
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shana
reviewed
Jul 5, 2017
| repositoryRemoteName = DefaultRepositoryRemoteName; | ||
| repositoryRemoteUrl = string.Empty; | ||
|
|
||
| Repository.OnActiveRemoteChanged += Repository_OnActiveRemoteChanged; |
Member
There was a problem hiding this comment.
Isn't this something that we always want to do regardless of whether there's a currently active remote or not?
Member
There was a problem hiding this comment.
Also, if this gets called twice, we're subscribing twice. We probably want to subscribe on enable and unsubscribe on disable?
shana
previously requested changes
Jul 5, 2017
Member
shana
left a comment
shana
left a comment
There was a problem hiding this comment.
I think there's some iffiness going on with the active remote subscription that needs handled
StanleyGoldman
added
work-in-progress
ready-for-review
and removed
ready-for-review
work-in-progress
labels
1 task
shana
force-pushed
the
fixes/settings-view-git-remote-update
branch
from
edaafcb to
b00656d
Compare
ActiveBranchChanged triggers RepositoryUpdate, so wait for that to happen and then watch for isbusy changed to wait for the RepositoryUpdate stuff.
Show branch name and url of the active remote. Add tooltips. Fix updating it when things change.
shana
previously approved these changes
Aug 7, 2017
shana
approved these changes
Aug 8, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #89
Fixes #94
Fixes #106
Depends on: