This repository was archived by the owner on Dec 5, 2024. It is now read-only.
Fix to update header when remote is removed #95
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… into them Use OnEnable/OnDisable instead of OnShow/OnHide, it's more consistent with Unity's naming and our own window class. AuthenticationView was missing some calls from the window, fixicate.
StanleyGoldman
changed the base branch from
master
to
fixes/settings-view-git-remote-update
StanleyGoldman
commented
Jul 5, 2017
| RepositoryManager.ActiveRemote.Value.Name.Should().Be("origin"); | ||
| RepositoryManager.ActiveRemote.Value.Url.Should().Be("https://github.com/EvilStanleyGoldman/IOTestsRepo.git"); | ||
|
|
||
| RepositoryManager.Repository.CloneUrl.Should().Be("https://github.com/EvilStanleyGoldman/IOTestsRepo"); |
Contributor
Author
There was a problem hiding this comment.
@shana would you have expected this value?
Refactoring BaseWindow and Subview to better handle initialization
StanleyGoldman
commented
Jul 5, 2017
| RepositoryManager.ActiveRemote.HasValue.Should().BeFalse(); | ||
|
|
||
| RepositoryManager.Repository.CloneUrl.Should().BeNull(); | ||
| RepositoryManager.Repository.Owner.Should().BeNull(); |
Contributor
Author
There was a problem hiding this comment.
The cause of the bug is the reason why these tests fail
Adding git fetch button
…r-view-git-remote-update # Conflicts: # src/UnityExtension/Assets/Editor/GitHub.Unity/UI/SettingsView.cs
CapnRat
reviewed
Jul 6, 2017
|
|
||
| GUILayout.FlexibleSpace(); | ||
|
|
||
| GUI.enabled = currentRemote != null; |
Collaborator
There was a problem hiding this comment.
Should get into the habit of using EditorGUI.Begin/EndDisabledGroup rather than setting GUI.enabled directly. Those utility methods handle nesting properly. (There's also EditorGUI.DisabledScope, for an IDisposable way of doing things.)
Member
|
This PR needs more detail on exactly what is going wrong, with repro steps. |
Member
|
Actually, closing this as it has nothing other than tests, might as well fix the original branch. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on: