This repository was archived by the owner on Jun 21, 2023. It is now read-only.
Nest review comments under reviews. #1613
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously we were loading a flat list of PR review comments into the `PullRequestModel`. GraphQL nests review comments under their relevant review. Reflect this in our models as it makes more sense.
grokys
changed the title
grokys
requested review from
StanleyGoldman,
drguthals,
jcansdale and
meaghanlewis
grokys
force-pushed
the
refactor/nest-review-comments
branch
from
268a230 to
48ca7c7
Compare
StanleyGoldman
suggested changes
May 7, 2018
Contributor
StanleyGoldman
left a comment
StanleyGoldman
left a comment
There was a problem hiding this comment.
There is just a spelling thing that I found.
Otherwise looks good.
Gonna test some.
| /// <returns>A model representing the posted comment.</returns> | ||
| Task<IPullRequestReviewCommentModel> PostStandaloneReviewCommentRepy( | ||
| /// <returns>A model representing the review for the posted comment.</returns> | ||
| Task<IPullRequestReviewModel> PostStandaloneReviewCommentRepy( |
Contributor
There was a problem hiding this comment.
Repy should probably be Reply
jcansdale
approved these changes
May 14, 2018
Collaborator
jcansdale
left a comment
jcansdale
left a comment
There was a problem hiding this comment.
Looking good and working well. Just one minor suggestion re: use of arrays.
|
|
||
| public IReadOnlyList<IPullRequestReviewCommentModel> Comments | ||
| { | ||
| get { return comments ?? (comments = new IPullRequestReviewCommentModel[0]); } |
Collaborator
There was a problem hiding this comment.
You could use:
get { return comments ?? Array.Empty<IPullRequestReviewCommentModel>(); }
Which I believe always returns the same singleton empty array.
Which should always return the same singleton empty array.
Contributor
Author
|
@StanleyGoldman could I get a 👍 on this? Fixed the misspelling. |
drguthals
reviewed
May 22, 2018
| } | ||
| } | ||
|
|
||
| IAccount assignee; |
Contributor
|
Tested and LGTM 👍 |
Contributor
Author
|
Superseded by #1712. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we were loading a flat list of PR review comments into the
PullRequestModel.ReviewCommentsproperty because this is how they were exposed in the REST API.GraphQL nests review comments under their relevant review, which makes a lot more sense, so this PR removes
PullRequestModel.ReviewCommentsand moves them toPullRequestReviewModel.Comments.This is the first step towards GraphQL-ification of Pull Requests; in upcoming PRs I intend to further this process by reading pull request models using purely GraphQL. At this point there are still a few hacks in place, and paging of PR reviews and review comments is not implemented. This will be addressed in upcoming PRs.