Skip to content
This repository was archived by the owner on Jun 21, 2023. It is now read-only.

Nest review comments under reviews. #1613

Closed
grokys wants to merge 11 commits into from
Closed

Nest review comments under reviews. #1613

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
6d8068d
Nest review comments under reviews.
grokys Apr 17, 2018
376c56e
Updated GraphQL and remove attempts at paging.
grokys Apr 19, 2018
dc1f6a2
Fill in some missing bits of info.
grokys Apr 19, 2018
106bc34
Merge branch 'master' into refactor/nest-review-comments
grokys Apr 19, 2018
48ca7c7
Updated Octokit.GraphQL package.
grokys Apr 19, 2018
0c62065
Merge branch 'master' into refactor/nest-review-comments
StanleyGoldman May 7, 2018
67c088f
Fix misspelling.
grokys May 7, 2018
c435556
Merge branch 'master' into refactor/nest-review-comments
jcansdale May 14, 2018
2f3ec54
Use Array.Empty.
grokys May 22, 2018
5803874
Merge branch 'master' into refactor/nest-review-comments
grokys May 22, 2018
8e458ed
Merge branch 'master' into refactor/nest-review-comments
grokys May 22, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Binary file removed lib/Octokit.GraphQL.0.0.2-alpha.nupkg
View file
Open in desktop
Binary file not shown.
Binary file added lib/Octokit.GraphQL.0.0.3-alpha.nupkg
View file
Open in desktop
Binary file not shown.
8 changes: 4 additions & 4 deletions src/GitHub.Api/GitHub.Api.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,12 +50,12 @@
<HintPath>..\..\packages\Newtonsoft.Json.10.0.3\lib\net45\Newtonsoft.Json.dll</HintPath>
<Private>True</Private>
</Reference>
<Reference Include="Octokit.GraphQL, Version=0.0.2.0, Culture=neutral, PublicKeyToken=0be8860aee462442, processorArchitecture=MSIL">
<HintPath>..\..\packages\Octokit.GraphQL.0.0.2-alpha\lib\netstandard1.1\Octokit.GraphQL.dll</HintPath>
<Reference Include="Octokit.GraphQL, Version=0.0.3.0, Culture=neutral, PublicKeyToken=0be8860aee462442, processorArchitecture=MSIL">
<HintPath>..\..\packages\Octokit.GraphQL.0.0.3-alpha\lib\netstandard1.1\Octokit.GraphQL.dll</HintPath>
<Private>True</Private>
</Reference>
<Reference Include="Octokit.GraphQL.Core, Version=0.0.2.0, Culture=neutral, PublicKeyToken=0be8860aee462442, processorArchitecture=MSIL">
<HintPath>..\..\packages\Octokit.GraphQL.0.0.2-alpha\lib\netstandard1.1\Octokit.GraphQL.Core.dll</HintPath>
<Reference Include="Octokit.GraphQL.Core, Version=0.0.3.0, Culture=neutral, PublicKeyToken=0be8860aee462442, processorArchitecture=MSIL">
<HintPath>..\..\packages\Octokit.GraphQL.0.0.3-alpha\lib\netstandard1.1\Octokit.GraphQL.Core.dll</HintPath>
<Private>True</Private>
</Reference>
<Reference Include="Serilog, Version=2.0.0.0, Culture=neutral, PublicKeyToken=24c2f752a8e58a10, processorArchitecture=MSIL">
Expand Down
2 changes: 1 addition & 1 deletion src/GitHub.Api/packages.config
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<?xml version="1.0" encoding="utf-8"?>
<packages>
<package id="Newtonsoft.Json" version="10.0.3" targetFramework="net461" />
<package id="Octokit.GraphQL" version="0.0.2-alpha" targetFramework="net461" />
<package id="Octokit.GraphQL" version="0.0.3-alpha" targetFramework="net461" />
<package id="Serilog" version="2.5.0" targetFramework="net461" />
</packages>
8 changes: 4 additions & 4 deletions src/GitHub.App/GitHub.App.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,12 +144,12 @@
<HintPath>..\..\packages\Microsoft.VisualStudio.Utilities.14.3.25407\lib\net45\Microsoft.VisualStudio.Utilities.dll</HintPath>
<Private>True</Private>
</Reference>
<Reference Include="Octokit.GraphQL, Version=0.0.2.0, Culture=neutral, PublicKeyToken=0be8860aee462442, processorArchitecture=MSIL">
<HintPath>..\..\packages\Octokit.GraphQL.0.0.2-alpha\lib\netstandard1.1\Octokit.GraphQL.dll</HintPath>
<Reference Include="Octokit.GraphQL, Version=0.0.3.0, Culture=neutral, PublicKeyToken=0be8860aee462442, processorArchitecture=MSIL">
<HintPath>..\..\packages\Octokit.GraphQL.0.0.3-alpha\lib\netstandard1.1\Octokit.GraphQL.dll</HintPath>
<Private>True</Private>
</Reference>
<Reference Include="Octokit.GraphQL.Core, Version=0.0.2.0, Culture=neutral, PublicKeyToken=0be8860aee462442, processorArchitecture=MSIL">
<HintPath>..\..\packages\Octokit.GraphQL.0.0.2-alpha\lib\netstandard1.1\Octokit.GraphQL.Core.dll</HintPath>
<Reference Include="Octokit.GraphQL.Core, Version=0.0.3.0, Culture=neutral, PublicKeyToken=0be8860aee462442, processorArchitecture=MSIL">
<HintPath>..\..\packages\Octokit.GraphQL.0.0.3-alpha\lib\netstandard1.1\Octokit.GraphQL.Core.dll</HintPath>
<Private>True</Private>
</Reference>
<Reference Include="PresentationCore" />
Expand Down
12 changes: 0 additions & 12 deletions src/GitHub.App/Models/PullRequestModel.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -177,18 +177,6 @@ public IReadOnlyList<IPullRequestReviewModel> Reviews
}
}

IReadOnlyList<IPullRequestReviewCommentModel> reviewComments = new IPullRequestReviewCommentModel[0];
public IReadOnlyList<IPullRequestReviewCommentModel> ReviewComments
{
get { return reviewComments; }
set
{
Guard.ArgumentNotNull(value, nameof(value));
reviewComments = value;
this.RaisePropertyChange();
}
}

IAccount assignee;
Copy link

@drguthals drguthals May 22, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did you remove that?

public IAccount Assignee
{
Expand Down
14 changes: 14 additions & 0 deletions src/GitHub.App/Models/PullRequestReviewModel.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,15 +1,29 @@
using System;
using System.Collections.Generic;
using GitHub.Extensions;

namespace GitHub.Models
{
public class PullRequestReviewModel : IPullRequestReviewModel
{
IReadOnlyList<IPullRequestReviewCommentModel> comments;

public long Id { get; set; }
public string NodeId { get; set; }
public IAccount User { get; set; }
public string Body { get; set; }
public PullRequestReviewState State { get; set; }
public string CommitId { get; set; }
public DateTimeOffset? SubmittedAt { get; set; }

public IReadOnlyList<IPullRequestReviewCommentModel> Comments
{
get { return comments ?? Array.Empty<IPullRequestReviewCommentModel>(); }
set
{
Guard.ArgumentNotNull(value, nameof(value));
comments = value;
}
}
}
}
Loading