Localization of GHfVS for Chinese - Simplified and Traditional #1714
Conversation
|
#18 Localization: Localize the extension to {insert language here} |
… localized, but there are some anomalies.
|
|
|
Thank you @maikebing for getting this started! We're really excited to see localization in our extension! 🎉 Let us know how we can help 👍 |
|
@sguthals GitHub context Menu I have not been able to localize, and I did not find the reason, perhaps I fell into some kind of misunderstanding. Do you know who is familiar with VSCT? |
|
Hi @maikebing! Maybe @jcansdale or @grokys can help you out with that! |
|
Hi @maikebing - to be honest this is something I've never done either! First of all, what have you already tried? Have you tried following the instructions at https://docs.microsoft.com/en-gb/visualstudio/extensibility/localizing-menu-commands? |
|
@sguthals When and who is going to review the code? |
|
@maikebing I'll test out this PR today. Perhaps @grokys can review the code? |
|
Thanks for keeping with this @maikebing! I am reviewing now. Localization is something I'm not very familiar with, so I apologise if I need to ask stupid questions ;) |
grokys
left a comment
grokys
left a comment
There was a problem hiding this comment.
This is looking great! I tested it, and though I cannot read Chinese and so can't attest to the translations, everything seems to be translated!
I've got just a few very small changes to request in the code. I know that this isn't the focus of this PR so I would be happy to make these changes myself - just let me know if you want me to do it.
Other than that, I think this looks good to merge!
|
|
||
| vsServices.Received(1).ShowMessageBoxInfo(expectMessage); | ||
| } | ||
| [Test] |
There was a problem hiding this comment.
Nit: needs a space between methods.
| { | ||
| await CouldNotResolve("TargetOwner", "CurrentOwner", Resources.NoResolveDifferentOwnerMessage); | ||
| } | ||
| [Test] |
There was a problem hiding this comment.
Also needs a newline here, and between the following methods.
| gitHubContextService.Received(1).TryOpenFile(repositoryDir, context); | ||
| } | ||
|
|
||
| [Test] |
| Padding="2 1" | ||
| Visibility="{Binding IsPending, Converter={ui:BooleanToVisibilityConverter}, FallbackValue=Collapsed}"> | ||
| <TextBlock FontSize="10">Pending</TextBlock> | ||
| <TextBlock FontSize="10" Text="{x:Static prop:Resources.Pending}"></TextBlock> |
There was a problem hiding this comment.
Now that the <TextBlock> doesn't have any content, it can use an auto-closing tag, i.e.:
<TextBlock FontSize="10" Text="{x:Static prop:Resources.Pending}"/>
This can be done in a lot of places, I won't add a comment for each one ;)
|
I was worried about what would happen if we add a new resource in English but there isn't a corresponding resource in the other language yet. I just tried this and it appears to fall-back to the English text, which is the best outcome we can hope for. |
|
@grokys Yes , it fall-back to English . |
|
This looks good to me. Thanks so much @maikebing! ✨ |
meaghanlewis
changed the title
#1714 incorrectly reverted the akavache submodule to an earlier version. Undo this.
Revert pull request #1714
|
Hi @maikebing! We tried to merge this but had some bugs. I learned a lot more about CrowdIn. Can I ask you to resubmit your original translations in this project? I would like to send you a private message. |
5 participants
Localization work started
Let's all translate together, click here to join https://crwd.in/github-visual-studio
HTTPS://CRWD.IN/GITHUBVSChinese (Simplified) -
Chinese (Traditional) -
English -