I18n pull request restore with CrowdIn support #1888

StanleyGoldman · 2018-08-30T23:29:02Z

This PR restores parts of #1714 and adds initial integration with CrowdIn.

It is currently only providing translations in zn-CH for our .resx files. We're going to need a more scalable solution than duplicating the entirety of our .vsct files for every language so those files are going to be tackled in a separate PR.

The neutral language en-US resources are being stored directly in the assemblies themselves with satellite assemblies only being used for translations. This is because WPF does not work well with satellite assemblies for the neutral language.

grokys · 2018-09-05T11:35:18Z

Merged #1871 into this branch, but it appears that the zh-HANS translations aren't present here. Why is that?

shana · 2018-09-06T10:56:26Z

crowdin.yml

+  - source: /src/**/Resources.en-US.resx
+    translation: /%original_path%/Resources.%locale%.resx
+  - source: /src/**/VSPackage.en-US.resx
+    translation: /%original_path%/VSPackage.%locale%.resx


I wouldn't do this one right now. This is information that's merged with the package for the marketplace and the extension list, not for the VS UI itself.

shana · 2018-09-06T10:56:49Z

crowdin.yml

+  - source: /src/**/VSPackage.en-US.resx
+    translation: /%original_path%/VSPackage.%locale%.resx
+  - source: /src/**/OcticonPaths.en-US.resx
+    translation: /%original_path%/OcticonPaths.%locale%.resx


There is nothing to translate on this, these are icons in svg format.

scripts/modules.ps1

codecov · 2018-09-11T11:25:03Z

Codecov Report

❗ No coverage uploaded for pull request base (master@0e64838). Click here to learn what that means.
The diff coverage is 25.92%.

@@            Coverage Diff            @@
##             master    #1888   +/-   ##
=========================================
  Coverage          ?   40.88%           
=========================================
  Files             ?      487           
  Lines             ?    18912           
  Branches          ?        0           
=========================================
  Hits              ?     7733           
  Misses            ?    11179           
  Partials          ?        0

Impacted Files	Coverage Δ
...Hub.InlineReviews/Views/InlineCommentPeekView.xaml	`0% <ø> (ø)`
...alStudio/Views/GitHubPane/PullRequestListView.xaml	`0% <ø> (ø)`
...isualStudio/Views/Dialog/LoginCredentialsView.xaml	`0% <ø> (ø)`
...udio/Views/GitHubPane/PullRequestCreationView.xaml	`0% <ø> (ø)`
src/GitHub.InlineReviews/Views/CommentView.xaml	`0% <ø> (ø)`
...Studio/Views/GitHubPane/PullRequestDetailView.xaml	`0% <ø> (ø)`
...GitHub.VisualStudio/Commands/OpenFromUrlCommand.cs	`0% <0%> (ø)`
...Studio/Views/Dialog/ForkRepositoryExecuteView.xaml	`0% <0%> (ø)`
....VisualStudio/Commands/OpenFromClipboardCommand.cs	`95.12% <100%> (ø)`
src/GitHub.VisualStudio.UI/Resources.Designer.cs	`8.64% <15.9%> (ø)`

grokys · 2018-09-11T11:29:43Z

@maikebing could take a look at this and tell me if I've got anything wrong?

And move hard-coded UI strings to resources. Co-Authored-By: MysticBoy <mysticboy@live.com>

jcansdale

Looking good! Just a suggestion about how we could handle resources in TestCase attributes and a white space issue.

test/GitHub.VisualStudio.UnitTests/Commands/OpenFromClipboardCommandTests.cs

jcansdale · 2018-09-11T13:07:08Z

test/GitHub.VisualStudio.UnitTests/Commands/OpenFromClipboardCommandTests.cs

            vsServices.DidNotReceiveWithAnyArgs().ShowMessageBoxInfo(null);
            gitHubContextService.Received(1).TryOpenFile(repositoryDir, context);
        }
+        [Test]


Resolve resources that start with a "#" using ResolveResources.

jcansdale

All good. 👍

jcansdale

Approve. 😕

maikebing · 2018-09-11T15:19:20Z

Looking good!

StanleyGoldman · 2018-09-11T19:48:40Z

Where are the resources specified to be satellites?

grokys · 2018-09-12T09:01:14Z

@StanleyGoldman the non-en-US .resx resources will be put in satellite assemblies.

StanleyGoldman changed the title ~~Internationalization~~ I18n Aug 30, 2018

StanleyGoldman force-pushed the internationalization branch from 7adfbf5 to 0661a30 Compare August 31, 2018 02:25

StanleyGoldman mentioned this pull request Aug 31, 2018

Localization of GHfVS for Chinese - Simplified and Traditional #1714

Merged

3 tasks

StanleyGoldman changed the title ~~I18n~~ I18n pull request restore with CrowdIn support Sep 1, 2018

shana suggested changes Sep 6, 2018

View reviewed changes

shana approved these changes Sep 6, 2018

View reviewed changes

grokys force-pushed the internationalization branch from dfd1f70 to 9839f9c Compare September 11, 2018 11:26

Added zn-CH translations for .resx files.

d45f6b1

And move hard-coded UI strings to resources. Co-Authored-By: MysticBoy <mysticboy@live.com>

grokys force-pushed the internationalization branch from 9839f9c to d45f6b1 Compare September 11, 2018 11:32

jcansdale suggested changes Sep 11, 2018

View reviewed changes

test/GitHub.VisualStudio.UnitTests/Commands/OpenFromClipboardCommandTests.cs Show resolved Hide resolved

test/GitHub.VisualStudio.UnitTests/Commands/OpenFromClipboardCommandTests.cs Show resolved Hide resolved

jcansdale reviewed Sep 11, 2018

View reviewed changes

Use TestCase tests rather than dispatcher tests

2baef97

Resolve resources that start with a "#" using ResolveResources.

jcansdale reviewed Sep 11, 2018

View reviewed changes

jcansdale approved these changes Sep 11, 2018

View reviewed changes

StanleyGoldman mentioned this pull request Sep 11, 2018

Unicode error can occur when viewing diff for PR files #1908

Closed

meaghanlewis added this to the 2.5.6 milestone Sep 11, 2018

grokys merged commit c1f15e1 into master Sep 12, 2018

grokys mentioned this pull request Sep 19, 2018

Internationalize VS menus/commands #1933

Merged

I18n pull request restore with CrowdIn support #1888

I18n pull request restore with CrowdIn support #1888

Uh oh!

Conversation

StanleyGoldman commented Aug 30, 2018 • edited by grokys Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

grokys commented Sep 5, 2018

Uh oh!

shana Sep 6, 2018

Choose a reason for hiding this comment

Uh oh!

shana Sep 6, 2018

Choose a reason for hiding this comment

Uh oh!

Uh oh!

codecov bot commented Sep 11, 2018

Codecov Report

Uh oh!

grokys commented Sep 11, 2018

Uh oh!

jcansdale left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

jcansdale Sep 11, 2018

Choose a reason for hiding this comment

Uh oh!

jcansdale left a comment

Choose a reason for hiding this comment

Uh oh!

jcansdale left a comment

Choose a reason for hiding this comment

Uh oh!

maikebing commented Sep 11, 2018

Uh oh!

StanleyGoldman commented Sep 11, 2018

Uh oh!

grokys commented Sep 12, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

StanleyGoldman commented Aug 30, 2018 •

edited by grokys

Loading