This repository was archived by the owner on Jun 21, 2023. It is now read-only.
Better failure modes #1853
Merged
Better failure modes #1853
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a login error occurs, display a message in our Team Explorer Connect pane with a Rety and Sign Out button.
grokys
requested review from
StanleyGoldman,
donokuda,
jcansdale and
meaghanlewis
Contributor
|
|
||
| void InvitationSectionPropertyChanged(object sender, PropertyChangedEventArgs e) | ||
| { | ||
| if (e.PropertyName == "IsVisible") |
Contributor
Author
There was a problem hiding this comment.
Yeah I was trying to stick with the style of the previous method which didn't use nameof, but you're right. I've converted this method and the previous to use nameof.
| } | ||
| else | ||
|
|
||
| if (notGitHubRepo) |
Contributor
Author
There was a problem hiding this comment.
No, this flag is set in the preceding block.
StanleyGoldman
approved these changes
Aug 22, 2018
Contributor
StanleyGoldman
left a comment
StanleyGoldman
left a comment
There was a problem hiding this comment.
Minor nits, otherwise cool..
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a login fails at VS startup, currently we just remove the connection from the TE connect page and pretend it never existed. With this PR, we show a message and allow the user to retry (in the case of non-auth-related) errors or sign out:
General connection error:
Auth error:
In addition, an error is shown in the GitHub pane with a link to open the Team Explorer Connect section to fix the problem:
The UI needs some love from @donokuda , but this is ready to play with!
Fixes #1305