C++: Add Variable.isConstexpr() #1012
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ian-semmle
added
the
depends on internal PR
jbj
previously approved these changes
Mar 1, 2019
Contributor
jbj
left a comment
jbj
left a comment
There was a problem hiding this comment.
This PR LGTM. I guess there's no concept of "declared constexpr but not actually constexpr" for variables. I tried to construct such a case, but I couldn't make one that would compile.
nickrolfe
reviewed
Mar 1, 2019
change-notes/1.20/analysis-cpp.md
Outdated
| * There is a new `Namespace.isInline()` predicate, which holds if the namespace was declared as `inline namespace`. | ||
| * The `Expr.isConstant()` predicate now also holds for _address constant expressions_, which are addresses that will be constant after the program has been linked. These address constants do not have a result for `Expr.getValue()`. | ||
| * There are new `Function.isDeclaredConstexpr()` and `Function.isConstexpr()` predicates. They can be used to tell whether a function was declared as `constexpr`, and whether it actually is `constexpr`. | ||
| * There is a new `Variable.isConstexpr()` predicates. It can be used to tell whether a variable is `constexpr`. |
nickrolfe
approved these changes
Mar 1, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.