Merge master into rc/1.20 #1031
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t ICryptoTransform that would be thread-unsafe, and potentially result in incorrect cryptographic results.
This new query is not written because it's the most interesting query we could write but because it's an IR-based query whose results are easy to verify.
This suite isn't referenced from anywhere yet, but it'll be included in a standard ODASA dist because the dist includes all files in the `c` and `cpp` directories. We can modify the nightly test jobs to include the experimental suite.
…ulgarciamsft/ql into users/raulga/ICryptoTransform
JavaScript: Add new query for ZipSlip (CWE-022).
Approved by asger-semmle
JS: Treat res.end() as alias for res.send() in Express
Approved by esben-semmle
…-type-inference-1 JS: Captured Nodes, type inference + a query
…form Detect usage of ICryptoTransform that would be thread-unsafe
…flow Python: Make "Modification of parameter with default" flow-sensitive.
…ness of default value.
Python: Add taint tracking guard for truthiness.
C++: Add Variable.isConstexpr()
C++: IR query for redundant null check
Approved by xiemaisi
This query is only appropriate for setuid programs. Since such programs are at most 0.1% of all code we analyse, I would say this query has a precision of at most 0.1%.
Contributor
|
LGTM. This pulls #1012 into 1.20, which is where it belongs because the corresponding internal PR was merged into 1.20. |
Contributor
|
LGTM as far as the Python changes are concerned. |
C++: Set cpp/command-line-injection precision=low
Contributor
Author
|
Replaced by #1032. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not something we usually do, but needed in this case to pull in PRs that were meant for rc/1.20 but got left behind when the RC branch was created.