Merge master into rc/1.20 #1032
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t ICryptoTransform that would be thread-unsafe, and potentially result in incorrect cryptographic results.
This new query is not written because it's the most interesting query we could write but because it's an IR-based query whose results are easy to verify.
This suite isn't referenced from anywhere yet, but it'll be included in a standard ODASA dist because the dist includes all files in the `c` and `cpp` directories. We can modify the nightly test jobs to include the experimental suite.
…ulgarciamsft/ql into users/raulga/ICryptoTransform
Approved by asger-semmle
JS: Treat res.end() as alias for res.send() in Express
Approved by esben-semmle
…ry-and-type-inference-1 JS: Captured Nodes, type inference + a query
…oTransform Detect usage of ICryptoTransform that would be thread-unsafe
…-with-flow Python: Make "Modification of parameter with default" flow-sensitive.
…ness of default value.
…-guard Python: Add taint tracking guard for truthiness.
C++: Add Variable.isConstexpr()
C++: IR query for redundant null check
…ccess Approved by xiemaisi
This query is only appropriate for setuid programs. Since such programs are at most 0.1% of all code we analyse, I would say this query has a precision of at most 0.1%.
C++: Set cpp/command-line-injection precision=low
Author
|
Python, C# and C++ changes were already approved on the previous PR, JavaScript changes lgtm as well. |
hvitved
approved these changes
Mar 4, 2019
jbj
approved these changes
Mar 4, 2019
This was referenced Mar 4, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
12 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replacement for #1031.