C++: Set cpp/command-line-injection precision=low #1024
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This query is only appropriate for setuid programs. Since such programs are at most 0.1% of all code we analyse, I would say this query has a precision of at most 0.1%.
geoffw0
reviewed
Mar 4, 2019
Contributor
geoffw0
left a comment
geoffw0
left a comment
There was a problem hiding this comment.
Is the issue here really the query, or our choices of taint source?
This query is part of the samate suite. It's important it stays there, but I don't have strong feelings about it remaining on LGTM.
Contributor
Author
|
The issue is that the query can't configure its taint sources to be essentially only network data. We're tracking that in https://jira.semmle.com/browse/ODASA-6209. This PR doesn't fix that underlying problem but makes sure it isn't visible on LGTM. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This query is only appropriate for setuid programs. Since such programs are at most 0.1% of all code we analyse, I would say this query has a precision of at most 0.1%.
We can talk about raising the precision to medium if someone can find at least one true positive on https://lgtm.com/rules/2152620561/alerts/.