Skip to content

C#: Exclude CIL arguments from ArgumentNode when they are compiled from source #14170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
hvitved merged 1 commit into from
Sep 12, 2023
Merged

C#: Exclude CIL arguments from ArgumentNode when they are compiled from source #14170

hvitved merged 1 commit into from
Sep 12, 2023

Conversation

@hvitved
Copy link
Contributor

@hvitved hvitved commented Sep 8, 2023

Identified via #14108.

@github-actions github-actions bot added the C# label Sep 8, 2023
@hvitved hvitved added the no-change-note-required This PR does not need a change note label Sep 8, 2023
@hvitved hvitved marked this pull request as ready for review September 8, 2023 17:29
@hvitved hvitved requested a review from a team as a code owner September 8, 2023 17:29
@tamasvajk
Copy link
Contributor

tamasvajk commented Sep 11, 2023

Identified via #14108.

Which is the case in #14108 that is being fixed here?

@hvitved
Copy link
Contributor Author

hvitved commented Sep 11, 2023

It was a consistency check reporting an ArgumentNode without an associated call.

@hvitved hvitved merged commit 49d5765 into github:main Sep 12, 2023
@hvitved hvitved deleted the csharp/cil-arg-exclude branch September 12, 2023 11:44
@hvitved hvitved mentioned this pull request Sep 13, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@tamasvajk tamasvajk tamasvajk approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

C# no-change-note-required This PR does not need a change note

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@hvitved @tamasvajk