Skip to content

C#: Exclude CIL arguments from ArgumentNode when they are compiled from source #14170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hvitved merged 1 commit into from
Sep 12, 2023
Merged

C#: Exclude CIL arguments from ArgumentNode when they are compiled from source #14170

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions csharp/ql/lib/semmle/code/csharp/dataflow/internal/DataFlowDispatch.qll
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -415,6 +415,9 @@ class CilDataFlowCall extends DataFlowCall, TCilCall {

CilDataFlowCall() { this = TCilCall(call) }

/** Gets the underlying CIL call. */
CIL::Call getCilCall() { result = call }

override DataFlowCallable getARuntimeTarget() {
// There is no dispatch library for CIL, so do not consider overrides for now
result.getUnderlyingCallable() = getCallableForDataFlow(call.getTarget())
Expand Down
2 changes: 1 addition & 1 deletion csharp/ql/lib/semmle/code/csharp/dataflow/internal/DataFlowPrivate.qll
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1181,7 +1181,7 @@ private module ArgumentNodes {
ExplicitArgumentNode() {
this.asExpr() instanceof Argument
or
this.asExpr() = any(CIL::Call call).getAnArgument()
this.asExpr() = any(CilDataFlowCall cc).getCilCall().getAnArgument()
}

override predicate argumentOf(DataFlowCall call, ArgumentPosition pos) {
Expand Down