C++: Add localExprFlow and localExprTaint #1806
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Change note needs to move to 1.23. |
Contributor
Author
|
Rebased to move change note to 1.23. |
rdmarsh2
reviewed
Aug 30, 2019
Contributor
rdmarsh2
left a comment
rdmarsh2
left a comment
There was a problem hiding this comment.
LGTM. Still needs docs review.
Contributor
|
Actually, one docs thing I just noticed - |
This is for ODASA-8053.
This shortens the queries a bit and ensures test coverage of the new predicate.
Contributor
Author
|
@rdmarsh2 I've added two commits to improve docs. @semmledocs-ac, can you do doc review on this PR? The QLDoc for the new predicates is mostly copied from either the corresponding predicates in Java or similar predicates around it, so we need to consider consistency if that should change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cc @lukecartey: this is for https://jira.semmle.com/browse/ODASA-8053.
For comparison, the corresponding PR for Java is #1795.
The
localExprTaintpredicate for IR-based taint tracking will follow in a separate PR.