C++: Get IR taint tracking library in sync #1886
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbj
force-pushed
the
ir-taint-shared
branch
from
d874912 to
7b09e41
Compare
Contributor
Author
|
Rebased to fix merge conflicts. |
rdmarsh2
reviewed
Sep 10, 2019
| */ | ||
| predicate localAdditionalTaintStep(DataFlow::Node nodeFrom, DataFlow::Node nodeTo) { | ||
| // Taint can flow into using ordinary data flow. | ||
| DataFlow::localFlowStep(nodeFrom, nodeTo) |
Contributor
There was a problem hiding this comment.
This conjunct contradicts the qldoc
This case was not supposed to be there -- that was the whole point of having the `localAdditionalTaintStep` predicate.
rdmarsh2
approved these changes
Sep 11, 2019
Contributor
rdmarsh2
left a comment
rdmarsh2
left a comment
There was a problem hiding this comment.
LGTM. Jenkins failures look transient - I've restarted the tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replays the work in #1757 and #1806 on the IR taint-tracking library.