Setting a SECURITY_DESCRIPTOR’s DACL to NULL

[raulgarciamsft]

Closing the gap between Semmle & PreFAST
This rule is equivalent to C6248

[jbj]

There are some Unicode curly apostrophes (’ instead of ') in this PR that's causing our tests to fail due to platform differences. Please rebase to remove them from the git history.

I've spotted them in the following places

• The commit message of the first commit.
• The @name and @description of the query.
• The two alert messages of the query.
• In the UnsafeDaclSecurityDescriptor.expected file, where they've been encoded as \u2019.

[raulgarciamsft]

Submitting fix. I will have to be careful in the future when using single quote ( ' ) to make sure my machine is not automatically replacing it.

[jbj]

I just noticed that some files use a mix of tabs and spaces. Sorry, but we have a CI check for that that only runs internally and not on external PRs. It'll start failing if we merge this. Please change tabs to spaces in all files.

Apart from that, this PR looks great, and I'll be happy to merge it. Thanks for the detailed help text and tests.

[jbj]

The tests are failing after 925c3b5 because all the line numbers in the expected file need to move down by one.

[raulgarciamsft]

Fixing the .expected file and a few more tabs that I found.

[jbj]

The last fix to the expected file re-introduced to \u2019, which is why the test is failing now.

There's also now a conflict in .gitignore after I merged your other PR. I'm not sure where those .gitignore changes are coming from, but maybe we should just ignore all of /.vs?

[raulgarciamsft]

Thanks… I have to find out why VS is changing the ' to ‘ … in the meantime I will try to get rid of them in the text.

[jbj]

Thanks for the contribution and the fixups! The tests are passing, except for a new test that's experimental for now and apparently broken.

[raulgarciamsft]

Thanks a lot