C++: Finalise docs for cpp/hresult-boolean-conversion and cpp/unsafe-dacl-security-descriptor #235
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit changes the name and description of the new `HResultBooleanConversion` query to follow our internal guidelines.
jbj
changed the title
jbj
force-pushed
the
hresult-boolean-qhelp
branch
from
169e685 to
308631e
Compare
Contributor
Author
jbj
commented
Oct 8, 2018
| |-----------------------------|-----------|--------------------------------------------------------------------| | ||
| | *@name of query (Query ID)* | *Tags* |*Aim of the new query and whether it is enabled by default or not* | | ||
| | Cast between HRESULT and a Boolean type (`cpp/hresult-boolean-conversion`) | external/cwe/cwe-253 | Finds logic errors caused by mistakenly treating the Windows `HRESULT` type as a Boolean instead of testing it with the appropriate macros. Enabled by default. | | ||
| | Setting a DACL to `NULL` in a `SECURITY_DESCRIPTOR` (`cpp/unsafe-dacl-security-descriptor`) | external/cwe/cwe-732 | This query finds code that creates world-writable objects on Windows by setting their DACL to `NULL`. Enabled by default. | |
Contributor
Author
There was a problem hiding this comment.
These two queries should have the "security" tag also.
|
LGTM |
Contributor
Author
|
I just resolved the changenote conflict in the web-based conflict editor on github.com. I hope that worked. |
Contributor
Author
|
@itauthor if you're happy with these changes, please approve and merge. |
itauthor
approved these changes
Oct 11, 2018
itauthor
approved these changes
Oct 11, 2018
itauthor
approved these changes
Oct 11, 2018
semmledocs-ac
approved these changes
Oct 11, 2018
felicitymay
approved these changes
Oct 11, 2018
aibaars
pushed a commit
that referenced
this pull request
Oct 14, 2021
Move comment so it's not treated as part of the precision metadata
smowton
pushed a commit
to smowton/codeql
that referenced
this pull request
Feb 7, 2022
…erface Extract companion objects from interfaces
MathiasVP
added a commit
to MathiasVP/ql
that referenced
this pull request
Aug 10, 2025
PS: Restructure generated files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I merged HResultBooleanConversion.qhelp and UnsafeDaclSecurityDescriptor.qhelp in #211 and #212, and I'd like to get docteam reviews for them in this follow-up PR.
I'll open a separate PR for change notes.
Cc @raulgarciamsft.