Python: Add toString information for all classes without such.
#2397
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Having `toString()` defined to be `none()` is a major headache when debugging, as `toString`-less results are silently elided. This PR puts dummy `toString`s in place of the `none()`s. (I am mostly creating this to see if it impacts our tests and/or the performance. If not, we may as well merge it.)
Contributor
Author
|
No impact on performance or alerts: https://git.semmle.com/gist/taus/664814474a8c734024176b483b4a7413 |
RasmusWL
approved these changes
Nov 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Having
toString()defined to benone()is a major headache when debugging,as
toString-less results are silently elided. This PR puts dummytoStringsin place of the
none()s.(I am mostly creating this to see if it impacts our tests and/or the
performance. If not, we may as well merge it.)