Skip to content

Python: Add toString information for all classes without such. #2397

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
RasmusWL merged 1 commit into from
Nov 21, 2019
Merged

Python: Add toString information for all classes without such. #2397

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion python/ql/src/external/CodeDuplication.qll
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,7 @@ class Copy extends @duplication_or_similarity
}

/** Gets a textual representation of this element. */
string toString() { none() }
string toString() { result = "Copy" }

/**
* Gets a block that extends this one, that is, its first token is also
Expand Down
2 changes: 1 addition & 1 deletion python/ql/src/semmle/python/Exprs.qll
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -419,7 +419,7 @@ abstract class Num extends Num_, ImmutableLiteral {

/* We want to declare this abstract, but currently we cannot. */
override string toString() {
none()
result = "Num with missing toString"
}

}
Expand Down
4 changes: 2 additions & 2 deletions python/ql/src/semmle/python/Keywords.qll
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ abstract class DictUnpackingOrKeyword extends DictItem {
abstract Expr getValue();

override string toString() {
none()
result = "DictUnpackingOrKeyword with missing toString"
}

}
Expand All @@ -70,7 +70,7 @@ abstract class DictDisplayItem extends DictItem {
abstract Expr getValue();

override string toString() {
none()
result = "DictDisplayItem with missing toString"
}

}
Expand Down
4 changes: 2 additions & 2 deletions python/ql/src/semmle/python/pointsto/PointsTo.qll
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ library class CfgOrigin extends @py_object {

string toString() {
/* Not to be displayed */
none()
result = "CfgOrigin"
}

/** Get a `ControlFlowNode` from `this` or `here`.
Expand Down Expand Up @@ -68,7 +68,7 @@ module CfgOrigin {
//
// string toString() {
// /* Not to be displayed */
// none()
// result = "CfgOrigin"
// }
//
// /** Get a `ControlFlowNode` from `this` or `here`.
Expand Down
4 changes: 2 additions & 2 deletions python/ql/src/semmle/python/types/Extensions.qll
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ import semmle.python.objects.ObjectInternal

abstract class PointsToExtension extends @py_flow_node {

string toString() { none() }
string toString() { result = "PointsToExtension with missing toString" }

abstract predicate pointsTo(Context context, ObjectInternal value, ControlFlowNode origin);

Expand All @@ -36,7 +36,7 @@ abstract class PointsToExtension extends @py_flow_node {
/** DEPRECATED -- Use PointsToExtension instead */
deprecated abstract class CustomPointsToFact extends @py_flow_node {

string toString() { none() }
string toString() { result = "CustomPointsToFact with missing toString" }

abstract predicate pointsTo(Context context, Object value, ClassObject cls, ControlFlowNode origin);

Expand Down