Fix outdated query console link #3817
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github#3546 changed the query but did not adjust the query link. Additionally the old query could not be re-run because some of the projects it targeted (gradle/gradle and eclipse-cdt/cdt) cannot be queried currently. It now queries all available demo projects of the query console instead.
Contributor
|
Thank you for your contribution @Marcono1234!
You're right, it makes sense to update the other links too. It would be great if you could include the updates in this PR too! (Though we can also do it in a follow-up PR, if you prefer.) Thank you again for your help 😃 |
shati-patel
approved these changes
Jul 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#3546 changed the query but did not adjust the query link.
Additionally the old query cannot be re-run because some of the projects it targeted (
gradle/gradleandeclipse-cdt/cdt) cannot be queried currently.The new query now queries all available demo projects of the query console instead.
Note that this affects some of the other query links as well, should the be updated too for consistency? Otherwise one part of the tutorial shows result for projects which the next part does not show.